Biomes are not set to the maximum protection range

Description

Describe the bug

• I am not sure if it’s a bug or working as intended, but FredtheDoggy pointed me that I should file this here on the issue tracker.

Steps to reproduce the behavior

• Have a configuration that allows protection range, example: 100 x 100
• Have a player generate an island, previously ensuring he has a permission for example only 50 x 50 size
• The biome on nether island will be set to the config value (example: nether_wastes) only on 50x50

(This is how our island range upgrade addon works):

• Have a player gain permission for example, 70 x 70 size now

• Set it to that size with range set command

• The biome is some kind of a default on the new gained surface (not handled by bbox, example: the_void biome)

Expected behavior

• I think it is expected to see bbox setting the biome all over the MAXIMUM protection range upon the island’s generation, and not the one the player has permission for at the moment

Screenshots and videos (Optional)

• None

Environment

Output of /bbox version (Mandatory)

[22:33:52] [Render thread/INFO]: [CHAT] Running PAPER 1.16.4.
[22:33:52] [Render thread/INFO]: [CHAT] BentoBox version: 1.15.2
[22:33:52] [Render thread/INFO]: [CHAT] Database: MYSQL
[22:33:52] [Render thread/INFO]: [CHAT] Loaded Game Worlds:
[22:33:52] [Render thread/INFO]: [CHAT] skyblock (skyblock): Overworld, [nether_color]Nether, [end_color]End
[22:33:52] [Render thread/INFO]: [CHAT] Loaded Addons:
[22:33:52] [Render thread/INFO]: [CHAT] BentoBox-InvSwitcher 0.0.4 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Biomes 1.13.0 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] BSkyBlock 1.14.3 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Challenges 0.8.4-SNAPSHOT-b428 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Chat 1.1.0-SNAPSHOT-LOCAL (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] ControlPanel 1.7.0 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] DimensionalTrees 1.6.1-SNAPSHOT-b81 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] IslandUpgrade 1.0 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Level 2.5.0 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Limits 1.15.0 (ENABLED)
[22:33:52] [Render thread/INFO]: [CHAT] Warps 1.10.0 (ENABLED)

Plugins (Optional)

Would say not relevant, but will provide if requested so in the meantime

Additional context (Optional)

• None for now

[tastybento]

This is a bit weird. I tried going to the nether and sure enough when I moved out of my island the biome changed. However, this should not happen because the biome is fixed to Nether Wastes (by default) and when you move out of it new chunks should be created by the BSkyBlock generator that sets the biome. So I wiped the world and did a fresh installed with Paper 318 and 345 and neither of those created different biomes in the Nether. So, I’m suspecting maybe this was either a vanilla bug or something whereby for a time the custom biomes were not being set and instead natural biomes were set. Can you try a new world as a test and see if you can replicate this?

[tastybento]

It’s fine. Interesting problem!