question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Various commands can expose vanished players

See original GitHub issue

Description

Describe the bug

Commands such as coop, trust or invite can expose vanished players.

Steps to reproduce the behavior

  1. Install BentoBox, BSkyBlock and a vanish plugin (e.g. ProtocolVanish).
  2. Connect the first account as a regular player.
  3. Create an island.
  4. Connect the second account as an administrator and put it in vanish.
  5. As the regular player, execute /is team invite <administrator>. => It will send the invite, thus letting the regular player know the administrator is online.

Screenshots and videos

None.

Expected behavior

Players “hidden” by vanish plugins should not be exposed through the commands. They should be deemed “offline” by the plugin. The same should go for tab-completion (and it has already been reported and fixed a while ago on ASB).

As far as I know, we can check if the player’s vanished by using Player#canSee().

Environment

Server

  • OS: Windows 10 x64
  • Java version: Java 8

Plugins

Plugins (2):
BentoBox, ProtocolVanish

BentoBox setup

BentoBox and Addons
Running SPIGOT 1.14.4.
BentoBox version: 1.8.0
Database: JSON
[...]
Loaded Addons:
BSkyBlock 1.6.0 (ENABLED)
Configuration
  • Database: JSON

Additional context

None.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
piotrskibaplcommented, Sep 5, 2020

I tested this on build #1860 and it works fine, thanks. I didn’t find any other possibilities to expose vanished players - in my opinion the issue could be closed now.

1reaction
Paul19988commented, Aug 23, 2020

https://github.com/BentoBoxWorld/BentoBox/pull/1499

Created PR to support making vanished players appearing offline (Note this PR should only be considered as a temporary fix for users & to be replaced at a later date with a more in-depth system.

EDIT: This has since been adjusted to use the correct methods & will need approval for merge

Read more comments on GitHub >

github_iconTop Results From Across the Web

/vanish <player> command – Minecraft Feedback
/vanish <player> command​​ This command will allow to be hidden from local and multiplayer worlds and players cant see your username also.
Read more >
Commands - Pages - Vanish No Packet - Bukkit Plugins
List features you can toggle · Command /vanish toggle <option>. Toggles the option stated; List of options: see - See vanished players; nopickup...
Read more >
Vanish by Whispers88 - uMod
Vanish allows players with permission to become completely invisible. Players, turrets, helicopters, NPCs, etc. will not be able to see, hear, or touch...
Read more >
Solved - Vanish all players except operators. - SpigotMC
I'm making a vanish plugin, and want operators to see vanished players but all other players to not. Anyone got a tip on...
Read more >
Tutorials/Command blocks and functions - Minecraft Wiki
Command blocks and functions can be used, among many other things, to change the difficulty, change the state of the weather, or give...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found