Used too much CPU time on onVehicleEntityCollision()

BkCommonLib version: 1.12-v2 (build 75 on Jenkins)

TrainCarts version: 1.12-v1

Spigot version: 1.12

---

Problem or bug:

TrainCarts used too much CPU time while processing VehicleEntityCollision event, here is a profiler log screenshot:

onVehicleEntityCollision used more than 60% CPU time and causing server lag, is there any improvement can be applyed on reflection works (which caused 40% CPU time)?

Expected behaviour:

Not use that much CPU.

Steps to reproduce:

I cannot ensure which part caused these works taking so much time, but use /train list command and get:

51 trains on the server (2 are moving)

But I think 2 moving trains should not take 60% CPU times.

cc @sntc06 @fntsrlike (who maintains the same server with me)

[bergerkiller]

https://ci.mg-dev.eu/job/BKCommonLib/137/ https://ci.mg-dev.eu/job/TrainCarts/64/

This has many new goodies and a way to avoid creating a DefaultEntityController that causes most of the lag. There will probably still be some hotspot in CommonEntity.get(), I’d be interested in seeing the full details of that if it still poses problems.

[sntc06]

We tried the new build, and the TPS is massively improved. Even in most densed area filled with minecarts in our server, TPS still have a decent 16~18. Thanks for all the great work you’ve done!

I attach the final profiling snapshot for your reference. Profile: https://www.dropbox.com/s/ttsr6sh8gq4643j/profile4.nps?dl=0 Image: https://www.dropbox.com/s/yjags8ykjmxamfd/profile4.png?dl=0