Displaying compounds

Just experimenting with this really nice package and stumbled along this error when trying to show a compound

Wondering if here could be a special case for handling cadquery compounds in this section of the code as I don’t think they have a .val() attribute

trying the show() function with pip install jupyter-cadquery==2.0.0-rc1 and also tried adding pip install git+https://github.com/bernhard-42/cadquery-massembly

~/anaconda3/lib/python3.8/site-packages/jupyter_cadquery/cadquery/cad_objects.py in show(render_mates, mate_scale, *cad_objs, **kwargs)
    359     mate_scale = mate_scale or get_default("mate_scale")
    360 
--> 361     assembly = to_assembly(*cad_objs, render_mates=render_mates, mate_scale=mate_scale)
    362 
    363     if assembly is None:

~/anaconda3/lib/python3.8/site-packages/jupyter_cadquery/cadquery/cad_objects.py in to_assembly(render_mates, mate_scale, *cad_objs)
    310             assembly.add_list(_from_vector(cad_obj, obj_id))
    311 
--> 312         elif isinstance(cad_obj.val(), Vector):
    313             assembly.add_list(_from_vectorlist(cad_obj, obj_id))
    314 

AttributeError: 'Compound' object has no attribute 'val'

[bernhard-42]

@Shimwell Not that I understand anything of this, but it looks nice and I thought to share how you can build colored models with jupyter-cadquery. Maybe you knew that anyhow, but I was actually curious how it would look like, so I gave it a try 😉

parts = []

colors = {
    "Plasma": (153, 50, 204),
    "CenterColumnShieldCylinder": (0, 0, 139),
    "BlanketFP": (102, 205, 170),
    "RotateStraightShape": (139, 0, 0),
    "ToroidalFieldCoilCoatHanger": (0, 0, 139),
    "PoloidalFieldCoilSet": (139, 0, 0),
    "PoloidalFieldCoilCaseSetFC": (128, 128, 0)
}

for shape_or_compound in my_reactor.shapes_and_components:
    name = shape_or_compound.__class__.__name__
    if isinstance(
            shape_or_compound.solid,
            (cq.occ_impl.shapes.Shape, cq.occ_impl.shapes.Compound)):
        for i, solid in enumerate(shape_or_compound.solid.Solids()):
            parts.append(Part(solid, name=f"{name}{i}", color=colors[name]))
    else:
        parts.append(Part(shape_or_compound.solid.val(), name=f"{name}", color=colors[name]))

PartGroup(parts)

[shimwell]

This is perfect timing and we were just looking for a way to color the components, we have a growing collection of reactors and the manual coloring was really starting to add up.

bernhard-42 has just shown us the way

@RemDelaporteMathurin and @billingsley-john I vote we add default RGB colors to all the parametric components and then we can remake this without having to do it manually and perhaps some of the images in the docs can be automated as well