Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Nami Wallet crashes when signing tx due to a buggy code

See original GitHub issue

Summary

A buggy code added 1.5 months ago is causing a crash when signing transactions.

https://github.com/Berry-Pool/nami-wallet/commit/93ca652be99006aa6b989fc63a5d0e474bc00e60#diff-93684c25afd055e453b1f64801526758960d648b2cf3fba1c2e4615a1b5ab927R407-R412

Details

This piece of code does not seem to perform anything, but it is causing a crash when signing a tx.

Loader.Cardano.TransactionUnspentOutput.new()
            .output()
            .amount()
            .coin()
            .compare();

Loader.Cardano.TransactionUnspentOutput.new requires two arguments, but this code provides zero. Therefore, the app crashes.

Please remove this buggy code

Appendix

fyi, here is the console error when Nami Wallet crashes:

Issue Analytics

State:
Created 2 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

alessandrokonradcommented, Mar 9, 2022

Yes fixed the issue already. Just have to wait until chrome store approves it.

1reaction

kc97blecommented, Mar 9, 2022

Thanks! Totally forgot to remove that line. Was probably some testing I did there…

Thanks for the prompt response.

This issue is blocking my development. I hope that the new version will be released soon.

As a side note, I believe that this issue would have been easily prevented if the repo uses TypeScript or a similar type-checking system. One possible way to prevent similar issues is to migrate to TypeScript. This migration process can be done incrementally and therefore does not hurt the development.

(btw, @kk-kien and me are the same person)