Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Action is pulling in binary files in a repo

See original GitHub issue

🐞 Describe the bug Syncing a file in a repo that has binary files will include those binary files in the PR and also modifies them.

Bug is recreated in this repo:

https://github.com/cds-snc/sre-test-repo

Here is the PR: https://github.com/cds-snc/sre-test-repo/pull/2

Please note this PR was triggered by another repo just to prove that it does occur in normal usage instead of just in the repo it was run in as I originally reported.

📚 To Reproduce

authenticate using a Token from a GitHub App installation
Add a binary file to a repo.

To create a basic binary file run the following command in bash

echo "00000000: ff" | xxd -r - binary.dat

Run the action and the binary file will be apart of the PR even if it is not part of the configuration.

💡 Expected behavior

I expect only the files identified to show up in the repo.

🖼️ Screenshots

Screen shot of files in PR in case it dissapears.

⚙️ Environment We pin Git SHA

Action version: 878d649c33c834dc1eff4c00f7fcf16bf281eb63 Link to Workflow file: https://github.com/cds-snc/sre-test-repo/blob/main/.github/workflows/sre-file-sync.yml

📋 Additional context

It converted a basic binary file from in hex, so I imagine there might be an issue with binary files and this action.

FF 0F to EF BF BD 0F

I also ran into an issue with a larger binary file, when using an image of about 960kb ran into the following error: stdout maxBuffer length exceeded

Some test runs: