get silently ignores unknown keyword arguments (in my case `ses`)

I am “inside” one of the tests, and decided to get a sample file. To my surprise - I got multiple:

431  	def test_derivative_getters():
432  	    synth_path = join(get_test_data_path(), 'synthetic')
433  	    bare_layout = BIDSLayout(synth_path, derivatives=False)
434  	    full_layout = BIDSLayout(synth_path, derivatives=True)
435  	    import pdb; pdb.set_trace()
436  ->	    assert bare_layout.get_spaces() == []

*(Pdb) from pprint import pprint

(Pdb) pprint(bare_layout.get(subject='05', ses='02', suffix='T1w'))
[<BIDSImageFile filename='/home/yoh/proj/bids/pybids/bids/tests/data/synthetic/sub-05/ses-01/anat/sub-05_ses-01_T1w.nii'>,
 <BIDSImageFile filename='/home/yoh/proj/bids/pybids/bids/tests/data/synthetic/sub-05/ses-01/anat/sub-05_ses-01_T1w.nii.gz'>,
 <BIDSImageFile filename='/home/yoh/proj/bids/pybids/bids/tests/data/synthetic/sub-05/ses-02/anat/sub-05_ses-02_T1w.nii'>,
 <BIDSImageFile filename='/home/yoh/proj/bids/pybids/bids/tests/data/synthetic/sub-05/ses-02/anat/sub-05_ses-02_T1w.nii.gz'>]
(Pdb) bids.__version__
'0.10.2+12.g8b5ca0e.dirty'

it does select correctly when I correctly specify session instead of ses. I would expect pybids to at least complain that whatever I have specified ses was not understood. Typos, API changes, etc could silently lead to incorrect results, thus imho it warrants AT LEAST a warning (I feel now that we had some discussion like that before, sorry if I am repeating myself 😉)

[tyarkoni]

Okay, so what convinced me you’re right is that I tried it your way and immediately broke a bunch of tests that were looking for an acq entity, which hasn’t existed since we changed it to acquisition. :p

Will update the PR.

[tyarkoni]

@effigies I still don’t like the idea of aliases, because it would require us to add an extra layer internally in a bunch of places (basically, anywhere there’s a DB query, we’d need to first check against an alias table). I also think it would encourage confusion, because currently the query names are exactly what they are in the file objects. If we allow searching for ses, people will probably start looking in myfile.ses, and that will fail (and I definitely don’t want to allow aliases at file object level).