Code quality fixes

Hi,

While reviewing this dependency, I’ve run across two code quality issues that could have future security implications:

1. Braceless conditionals are used in various places. This gist goes into more detail about why this is a security risk.
2. Promisification is done manually with new Promise, which is error-prone and tends to invite “callback creep” over time; ie. increasing amounts of non-Promises code stuffed into the new Promise callback, which results in unreliable error handling. This should use something like util.promisify instead.

To be clear; neither of these are immediate security issues, and so there is no time pressure. They are “just” code quality issues that are likely to introduce a bug and/or vulnerability in any future updates 😃

[joepie91]

Thank you for the comments and heart attack inducing title 😃

Hah, sorry! I bolded the “not an immediate issue” thing in the hopes that it wouldn’t cause this reaction, but I guess I didn’t consider the title 😃

tweaking the linter settings might catch these problems moving forward.

I believe there’s an ESLint rule for requiring brackets, but not for the use of new Promise. But it’s possible that I just missed it.

If you’d like to make a PR with the needed changes I would be open to merging it.

I’m about to start my weekend now, but will do so next week. Thanks!

[junderw]

I made a PR that hopefully addresses all issues (by limiting the new Promise to a small wrapper function that no one should have to touch ever, basically a manual promisify, and then adding the curly rule to TSLINT)