Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Don't use the TypeScript `any` type for return types

See original GitHub issue

Functions in the JS API use the TypeScript any type for return types. Please instead use real types so we can use these APIs with type safety.

For example:

https://github.com/BitGo/BitGoJS/blob/7862547b3e40f6836d25c77fdb1a0ffbebbfc9c7/modules/sdk-core/src/bitgo/wallet/wallet.ts#L469

In the mean time, it’s not clear the right way to manually type this.

Feature Description

Don’t use the TypeScript any type for return types; instead use detailed types that describe the possible variations of the real data that could be returned.

Motivation

So we can use the BitGo JS SDK with type safety.

Context

N/A

Issue Analytics

State:
Created a year ago
Reactions:1
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

byhowcommented, Aug 31, 2022

Hi @jaydenseric, refactoring this particular function, would require us to also refactor all the modules for our SDK. We created an internal ticket to track this, and we’ll assess and scope the effort soon. In the meantime, we’ll keep this issue open. Thank you!

0reactions

jaydensericcommented, Aug 19, 2022

Not stale.