question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Please fix auto login for Comcast/Xfinity users

See original GitHub issue

The issue is that if you are an Xfinity customer and you try to use youtube-dl while on your home Xfinity connection (in other words you are not trying to log in through some other ISP) it will not allow you to login unless it completes its auto-login sequence. This 8 line fix allows that and has worked fine for a year and a half now, it was originally posted in a comment on a related issue on the other site, but for some inexplicable reason was never added to the main program. This is the output of the diff command comparing the original adobepass.py to the patched one, as you can see there are only 8 lines to be added (6 if you don’t count the comments):

$ diff -u adobepass.py.original adobepass.py.patched
--- adobepass.py.original	2018-10-17 01:22:56.000000000 -0400
+++ adobepass.py.patched	2019-04-23 08:53:36.000000000 -0400
@@ -1433,6 +1433,14 @@
                             provider_redirect_page, 'oauth redirect')
                         self._download_webpage(
                             oauth_redirect_url, video_id, 'Confirming auto login')
+                    elif 'automatically signed in with' in provider_redirect_page:
+                        # Seems like comcast is rolling up new way of automatically signing customers
+                        oauth_redirect_url = self._html_search_regex(
+                            r'continue:\s*"(https://oauth.xfinity.com/oauth/authorize\?.+)"',
+                            provider_redirect_page, 'oauth redirect (signed)')
+                        # Just need to process the request. No useful data comes back
+                        self._download_webpage(
+                            oauth_redirect_url, video_id, 'Confirming auto login')
                     else:
                         if '<form name="signin"' in provider_redirect_page:
                             provider_login_page_res = provider_redirect_page_res

I should clarify that I did not write this patch, just copied it from a comment/submission on the original project.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:9

github_iconTop GitHub Comments

1reaction
tv21commented, Oct 27, 2020

Yes it is, and I also have no idea why they just kept ignoring it because it has worked great if you know how to patch it yourself.

0reactions
sufr3akcommented, Nov 11, 2020

I’m curious if @merval knows why this may fail off network.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Ways To Sign Into Your Xfinity Account
To sign in, use your Xfinity ID (email, mobile, username) on the Xfinity My Account app or in your account. You can also...
Read more >
‎Keeps asking me to sign in | Xfinity Community Forum
Comcast should fix this because there's not reason it needs to be doing 3rd party tracking for customers logging in to their own...
Read more >
Can't log in to the Web site from my desktop - Xfinity Forum
Go into your password manager and clear any and all saved passwords related to Comcast / Xfinity urls. · After they are all...
Read more >
email issues - auto complete addresses
For the past week, email addresses are not auto completing when I start typing them out in "compose". I've gone through settings and ......
Read more >
Login Data Error Message - Xfinity Community Forum
... email on the Xfinity web site. The provided login data to access mail server imap.Comcast.net seem to be wrong. Please correct them....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found