Please fix auto login for Comcast/Xfinity users
See original GitHub issueThe issue is that if you are an Xfinity customer and you try to use youtube-dl while on your home Xfinity connection (in other words you are not trying to log in through some other ISP) it will not allow you to login unless it completes its auto-login sequence. This 8 line fix allows that and has worked fine for a year and a half now, it was originally posted in a comment on a related issue on the other site, but for some inexplicable reason was never added to the main program. This is the output of the diff command comparing the original adobepass.py to the patched one, as you can see there are only 8 lines to be added (6 if you don’t count the comments):
$ diff -u adobepass.py.original adobepass.py.patched
--- adobepass.py.original 2018-10-17 01:22:56.000000000 -0400
+++ adobepass.py.patched 2019-04-23 08:53:36.000000000 -0400
@@ -1433,6 +1433,14 @@
provider_redirect_page, 'oauth redirect')
self._download_webpage(
oauth_redirect_url, video_id, 'Confirming auto login')
+ elif 'automatically signed in with' in provider_redirect_page:
+ # Seems like comcast is rolling up new way of automatically signing customers
+ oauth_redirect_url = self._html_search_regex(
+ r'continue:\s*"(https://oauth.xfinity.com/oauth/authorize\?.+)"',
+ provider_redirect_page, 'oauth redirect (signed)')
+ # Just need to process the request. No useful data comes back
+ self._download_webpage(
+ oauth_redirect_url, video_id, 'Confirming auto login')
else:
if '<form name="signin"' in provider_redirect_page:
provider_login_page_res = provider_redirect_page_res
I should clarify that I did not write this patch, just copied it from a comment/submission on the original project.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:9
Top GitHub Comments
Yes it is, and I also have no idea why they just kept ignoring it because it has worked great if you know how to patch it yourself.
I’m curious if @merval knows why this may fail off network.