MQTT switches broken

Describe the bug The MQTT switches are completely broken if the clips option for a camera is set to False. When starting Frigate, it sends the current state of the clips camera option to the topics clips/state, snapshots/state and detect/state. And since it also sets the retain flag, when restarting frigate everything backfires and sets clips, snapshots and detect to OFF since the handler also sets stuff when it arrives on the state topic.

mqtt.py:

    for name in config.cameras.keys():
        client.publish(f"{mqtt_config.topic_prefix}/{name}/clips/state", 'ON' if config.cameras[name].clips.enabled else 'OFF', retain=True)
        client.publish(f"{mqtt_config.topic_prefix}/{name}/snapshots/state", 'ON' if config.cameras[name].clips.enabled else 'OFF', retain=True)
        client.publish(f"{mqtt_config.topic_prefix}/{name}/detect/state", 'ON' if config.cameras[name].clips.enabled else 'OFF', retain=True)

def on_detect_command(client, userdata, message):
        payload = message.payload.decode()
        logger.debug(f"on_detect_toggle: {message.topic} {payload}")

        camera_name = message.topic.split('/')[-3]
        command = message.topic.split('/')[-1]

        detect_settings = config.cameras[camera_name].detect

        if payload == 'ON':
            if not camera_metrics[camera_name]["detection_enabled"].value:
                logger.info(f"Turning on detection for {camera_name} via mqtt")
                camera_metrics[camera_name]["detection_enabled"].value = True
                detect_settings._enabled = True
        elif payload == 'OFF':
            if camera_metrics[camera_name]["detection_enabled"].value:
                logger.info(f"Turning off detection for {camera_name} via mqtt")
                camera_metrics[camera_name]["detection_enabled"].value = False
                detect_settings._enabled = False
        else:
            logger.warning(f"Received unsupported value at {message.topic}: {payload}")

        if command == "set":
            state_topic = f"{message.topic[:-4]}/state"
            client.publish(state_topic, payload, retain=True)

Version of frigate 0.8.0 RC1

Logs

frigate.mqtt                   INFO    : MQTT connected
frigate.mqtt                   DEBUG   : on_clips_toggle: frigate/driveway/clips/state OFF
frigate.mqtt                   DEBUG   : on_clips_toggle: frigate/frontdoor/clips/state OFF
frigate.mqtt                   DEBUG   : on_clips_toggle: frigate/backyard/clips/state OFF
frigate.mqtt                   DEBUG   : on_snapshots_toggle: frigate/driveway/snapshots/state OFF
frigate.mqtt                   INFO    : Turning off snapshots for driveway via mqtt
frigate.mqtt                   DEBUG   : on_snapshots_toggle: frigate/frontdoor/snapshots/state OFF
frigate.mqtt                   INFO    : Turning off snapshots for frontdoor via mqtt
frigate.mqtt                   DEBUG   : on_snapshots_toggle: frigate/backyard/snapshots/state OFF
frigate.mqtt                   INFO    : Turning off snapshots for backyard via mqtt
frigate.mqtt                   DEBUG   : on_detect_toggle: frigate/driveway/detect/state OFF
frigate.mqtt                   INFO    : Turning off detection for driveway via mqtt
frigate.mqtt                   DEBUG   : on_detect_toggle: frigate/frontdoor/detect/state OFF
frigate.mqtt                   INFO    : Turning off detection for frontdoor via mqtt
frigate.mqtt                   DEBUG   : on_detect_toggle: frigate/backyard/detect/state OFF
frigate.mqtt                   INFO    : Turning off detection for backyard via mqtt
frigate.app                    INFO    : Camera processor started for backyard: 34
detector.cpu1                  INFO    : Starting detection process: 31
frigate.app                    INFO    : Camera processor started for frontdoor: 35
frigate.app                    INFO    : Camera processor started for driveway: 36
frigate.app                    INFO    : Capture process started for backyard: 37
frigate.app                    INFO    : Capture process started for frontdoor: 38
frigate.app                    INFO    : Capture process started for driveway: 41

[blakeblackshear]

Wow. I can’t believe I missed that.

[neonpak]

I was referring to this line if config.cameras[name].clips.enabled. You are sending the state of config.cameras[name].clips.enabled to clips/state, snapshots/state and detect/state.