Support / Provide include files to simplify advance configuration
See original GitHub issueRight now there are a lot of FFMPEG settings to support server acceleration and to FIX specific camera issues however many of these will be common to large groups of users.
Home assistant and a lot of other YAML configured projects use the idea of importing include files for simplifying the main config and also for storing secrets etc.
What I would propose is to:
- support user made include files or document it if already possible.
- Bundle / include a library of common include files (with each frigate release) for Server HW / Camera HW specific settings…
IE instead of depending on documentation for Intel support
Change this:
ffmpeg:
hwaccel_args:
- -hwaccel
- vaapi
- -hwaccel_device
- /dev/dri/renderD128
- -hwaccel_output_format
- yuv420p
to
ffmpeg:
hwaccel_args: !include global_hwaccel_args_intel_7thGen_or_less.yaml
Instead of a large FFMPEG block in a camera section.
reolink:
ffmpeg:
hwaccel_args:
input_args:
- -avoid_negative_ts
- make_zero
- -fflags
- nobuffer+genpts+discardcorrupt
- -flags
- low_delay
- -strict
- experimental
- -analyzeduration
- 1000M
- -probesize
- 1000M
- -rw_timeout
- "5000000"
to
reolink:
ffmpeg: !include camera_ffmpeg_reolink_generic.yaml
If the include files where maintained with the releases it would help make upgrades easier going forward, and would make the config file a bit less lengthy.
Documentation would also possibly need less updating if it just generally referred to looking at the include library for matching configurations.
Using include files in the camera section in general would be very helpful. Many users will have the same over all settings for several cameras so being able to use includes would clean up these sections.
Issue Analytics
- State:
- Created a year ago
- Comments:12
Top GitHub Comments
Maybe I am not understanding this but since this is all based on docker is this not easily fixed by moving the config file or the includes into their own path / folder on the host and mappings that folder for that use?/config/includes but only includes is mapped with folder access?
Also going back to presets instead of !include you go !preset and use a named preset and !preset just maps to a folder in the image.
End of the day these are just ideas.
Looking at my current config I would love to take this:
And turn it into
Having each camera as a file would greatly simplify version control and make cloning, swapping back and forth between versions of a config, much easier than tracking a DIFF in the main config file.
Still think this is a good idea but will let this go stale next time around. The more I tune detection min_size etc per camera the longer my config file gets.