question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Generic Lobby improvements

See original GitHub issue

Ideas for improvement:

  • Poll for changes to state so that refreshes are not required. (done in #510)
  • Option to automatically remove room if all users leave the room (made the default behaviour in #276)
  • Add optional unique name check
  • Add optional limit for rooms (will disable ‘create room’ button if rooms number reached limit)
  • Provide ability to customize ui when waiting for an API call (i.e. loading state)
  • Rename gameInstances to rooms (easier to understand). (done in #406 and then re-renamed to matches in #704)
  • Show leave button even if the game is ready to play. (done in #510)

EDIT: Design document by @flamecoals: link

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:6
  • Comments:26 (26 by maintainers)

github_iconTop GitHub Comments

2reactions
nicolodaviscommented, Oct 1, 2019

My thinking was that we just provide the REST API (which can be consumed in many ways). In addition to that, we also provide a default lobby implementation (that can be styled). If someone wants to build a completely different lobby, they can go ahead and build that on top of our REST API.

What we should be focusing on is making our existing lobby generic enough that people won’t see the need to re-implement it.

However, I can see some value in providing a client-side abstraction if we want to hide the communication between client and server (for example, if we want to start using sockets). Maybe we should revisit this idea once our lobby implementation is starting to do complex things like that.

1reaction
vdfdevcommented, May 5, 2019

@francoijs Thanks for the help! Approved all your suggestions. I will probably do the first PR soon on this.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Generic Lobby improvements · Issue #354 - GitHub
Yes, I'm envisioning just one global lobby, and you can create games inside that lobby (each game can be a different kind). Players...
Read more >
Lobby and Hallway Improvements Making a Good First ...
Lobby and Hallway Improvements. There's an old saying, 'You never get a second chance to make a first impression,' and that holds very...
Read more >
Drug lobby stalls pro-generics bill - Fierce Pharma
Getting generic drugs to market faster? ... Drug lobby stalls pro-generics bill ... accompanied by significant quality-of-life improvements.
Read more >
A bitter pill: how big pharma lobbies to keep prescription drug ...
First, we explore the size of the drug pricing lobby by examining lobbying ... and an amendment titled “Improving Access to Generic Drugs....
Read more >
Pharmaceutical Lobby Reigns Supreme in Washington
The Generic Drug Lobby: Shorter Reach, Similar Tactics ... An improved approach to measuring drug innovation finds steady rates of ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found