ImageRGBA error during change events

Since https://github.com/bokeh/bokeh/pull/6313 was merged there is an error in the ImageRGBA._set_data method where it is being passed two copies of the source. This means that the indicesvariable incorrectly refers to the source resulting in an error on this line

if indices? and indices.indexOf(i) < 0

Exception in Comm callback TypeError: e.indexOf is not a function

because the source does not have an indexOf method. I haven’t tried reproducing this using bokeh server yet but here is a minimal example to reproduce this in the notebook:

    from __future__ import division
    
    import numpy as np
    
    from bokeh.plotting import figure, show, output_notebook
    from bokeh.io import push_notebook
    from bokeh.models import ColumnDataSource
    
    output_notebook()
    
    N = 20
    img = np.empty((N,N), dtype=np.uint32)
    view = img.view(dtype=np.uint8).reshape((N, N, 4))
    for i in range(N):
        for j in range(N):
            view[i, j, 0] = int(i/N*255)
            view[i, j, 1] = 158
            view[i, j, 2] = int(j/N*255)
            view[i, j, 3] = 255
    
    p = figure(x_range=(0,10), y_range=(0,10))
    
    cds = ColumnDataSource(data=dict(image=[img]))
    
    # must give a vector of images
    p.image_rgba(image='image', source=cds, x=0, y=0, dw=10, dh=10)
    
    handle = show(p, notebook_handle=True)  # open a browser
    
    img[:20, :20] += 10
    cds.data['image'][0] = img
    push_notebook(handle=handle)

Tested on: bokeh 0.12.6dev7

[bryevdv]

@philippjfr this should be fixed in master now

[mattpap]

@bryevdv, I submitted I PR (#6373).