belongsToMany incorrectly assumes idAttribute is a column name.

My column names are snake_case, but my attribute names are camelCase. My database’s primary key is entity_id, for instance, the accounts table has a primary key of account_id.

The belongsToMany association is incorrectly using the camelized idAttribute to join the tables.

// the code below will run this query. 
// Notice the incorrect column name in the ON clause:
// 'select "foos".*, "bars_foos"."bar_id" as "_pivot_bar_id", "bars_foos"."foo_id" as "_pivot_foo_id" 
// from "foos" inner join "bars_foos" on "bars_foos"."foo_id" = "foos"."fooId" 
// where "bars_foos"."bar_id" = $1'

var Foo = bookshelf.Model.extend({
    tableName: 'foos',
    idAttribute: 'fooId', // column name is actually foo_id.

    format: function(attrs) {
        return {
            'foo_id': attrs.fooId
        };
    },

    parse: function(record) {
        return {
            fooId: record['foo_id']
        };
    }
});

var Bar = bookshelf.Model.extend({
    tableName: 'bars',
    foos: function() {
        return this.belongsToMany(Foo, 'bars_foos', 'bar_id', 'foo_id');
    }
});

var foos = Bar.forge({id: 1}).related('foos').fetch();

[tgriesser]

Yeah, this is incorrect. I’m going to actually provide support for camel casing the keys directly in the library in the upcoming minor version, but in the meantime I’ll see if I can fix this one. Thanks for the test case.

[crunchtime-ali]

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.

If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.

We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion. Let’s make Bookshelf great again