Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

distribution package contains unecessary files

See original GitHub issue

distribution package contains unecessary files

Introduction

distribution packages - those published on npm - should preferably be slim, and contain only the run-time sources, with a set of minimum registry requirements (such as package.json, readme and license).

however, the distribution package comes with unecessary files and folders

Issue Description

True for 0.10.4 - The distribution contains:

src
scripts
.babelrc
.npmignore

Steps to reproduce issue

npm install bookshelf
tree node_modules/bookshelf

Expected behaviour

Folder tree should include:

lib
README.md/LISENSE/CHANGELOG.md
package.json

Actual behaviour

D:\ws>tree node_modules\bookshelf /F
Folder PATH listing for volume DATA
Volume serial number is 20CC-A0A2
D:\WS\NODE_MODULES\BOOKSHELF
│   .babelrc
│   .npmignore
│   bookshelf.js
│   CHANGELOG.md
│   LICENSE
│   package.json
│   README.md
│
├───lib
│   │   bookshelf.js
│   │   collection.js
│   │   constants.js
│   │   eager.js
│   │   errors.js
│   │   extend.js
│   │   helpers.js
│   │   model.js
│   │   relation.js
│   │   sync.js
│   │
│   ├───base
│   │       collection.js
│   │       eager.js
│   │       events.js
│   │       model.js
│   │       promise.js
│   │       relation.js
│   │
│   └───plugins
│           pagination.js
│           registry.js
│           virtuals.js
│           visibility.js
│
├───scripts
│       build.js
│       gh-pages.sh
│       jsdoc.config.json
│       jsdoc.sh
│       postpublish.sh
│       promise.js
│
└───src
    │   bookshelf.js
    │   collection.js
    │   constants.js
    │   eager.js
    │   errors.js
    │   extend.js
    │   helpers.js
    │   model.js
    │   relation.js
    │   sync.js
    │
    ├───base
    │       collection.js
    │       eager.js
    │       events.js
    │       model.js
    │       promise.js
    │       relation.js
    │
    └───plugins
            pagination.js
            registry.js
            virtuals.js
            visibility.js

Issue Analytics

State:
Created 6 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

2reactions

mrhwickcommented, Nov 2, 2017

You should have an invite to the organization and maintainer team again. I thought I had added everyone, but I must have missed some people who weren’t on the bookshelf organization but the repo itself. It would be helpful if you could also add one of the more recently active maintainers, or all of the maintainers team to the npm package administration as well.

0reactions

ricardogracacommented, Nov 16, 2017

Fixed in version 0.11.0, although you should be installing 0.11.1 due to a missing file in the previous version.