Error: Transaction query already complete.

I’ve been trying to achieve this code to work for days now, though unsuccessfully.

So I have model of an “Object”, which has many “Spots” and those have many “Tasks” (both are working hasMany relations).

What I am trying to do is when I soft delete an Object (just passing a flag isDeleted: true), I also need to pass this flag to all of it’s Spots and to all of it’s Tasks.

   const updatedObjekt = await Bookshelf.transaction( async (trx) => {
        // if deleting object
        if (req.body.isDeleted) {
            const relatedSpots = await new Spot().where({objektId: objekt.attributes.id}).fetchAll();
            //soft delete spots
            relatedSpots.forEach(async (spot) => {
                const relatedTasks = await new Task().where({spotId: spot.attributes.id}).fetchAll();
                //soft delete tasks
                relatedTasks.forEach(async (task) => {
                    const updatedTask = await task.save({isDeleted: true}, {method:"update", patch: true, transacting: trx});
                });
                const updatedSpot = await spot.save({isDeleted: true}, {method:"update", patch: true, transacting: trx});
            });
        }
        //save objekt
        const updatedObjekt = await objekt.save(req.body, {method:"update", patch: true, transacting: trx, returning: '*'});
        if (managerId) {
            await updatedObjekt.managedBy().detach();
            await updatedObjekt.managedBy().attach(managerId);
        }
        return updatedObjekt;
    });

I end up with this error: UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: Transaction query already complete.

Is there any way to achieve this please?

[fl0w]

You should at least add await knex('tasks').transacting(trx).where({spotId: spot.id}).update('isDeleted', true);

[MisooB]

thank you all for your help. I’ve managed to get rid of errors by following:

relatedSpots.forEach(async (
      const updatedSpot = await spot.save({isDeleted: true}, {method:"update", patch: true, transacting: trx});
      await knex('tasks').where({spotId: spot.id}).update('isDeleted', true);
});

first line adds ‘isDeleted’ flag to all spots and second one does the same with tasks. Don’t know if this is super viable or not but it’s working for now.