fetch doesn't return null if query returns no results

Returns a promise, which will resolve with the fetched Model, or null if the model isn’t fetched.

    // Fetch a model based on the currently set attributes,
    // returning a model to the callback, along with any options.
    // Returns a deferred promise through the Bookshelf.sync.
    // If `{require: true}` is set as an option, the fetch is considered
    // a failure if the model comes up blank.
    fetch: function(options) {
      var model = this;
      options || (options = {});
      return this.sync(options)
        .first()
        .then(function(resp) {
          if (resp && resp.length > 0) {
            model.set(model.parse(resp[0], options), _.extend({silent: true}, options))._reset();
            if (!options.withRelated) return resp;
            return new EagerRelation(model, resp)
              .fetch(options)
              .then(function() { return resp; });
          } else {
            if (options.require) return when.reject(new Error('EmptyResponse'));
            model.clear({silent: true})._reset();
            return {};
          }
        })
        .then(function(resp) {
          model.trigger('fetched', model, resp, options);
          console.log ('hello')
          return model;
        });
    },

It returns model with empty attributes.

I’m trying to write a findOrCreate method, so returning null would be handy.

[rhys-vdw]

The code example is incorrect. You want to set require: false. The returned value should then be null. If there is a still a problem please open a new issue as this relates to an older version of Bookshelf. If it does work please paste the revised code here for future reference. Thanks.

[vjpr]

Its a pretty common workflow to get and check if a model exists. This is a lot of code for such a common operation.

I think its best to provide another option to allow the success handler to return a null value.