fetchPage not working in current version

We tried using fetchPage instead of fetch or fetchAll.

The default {page: 1, pageSize: 10} is returned.

However if we try including withRelated or different page and pageSize options it continues to return the default and does not work correctly. Anyone else experiencing this?

Here’s what a part of our code looks like:

fetchForCriteria: function (criteria) {
        return this.query(function (q) {
            for (var param in criteria) {

                if (criteria[param] == null || criteria[param] == undefined || criteria[param] == "")
                    continue;

                if (param == 'orderby') {
                    // q.orderBy(criteria[param], criteria['direction'] || 'desc');
                }
                else if (param == 'direction') {
                    continue;
                }
                else if (param == 'brand_id') {
                    continue;
                }
                else if (param == 'list_id') {
                    continue;
                }
                else if (param == 'image_id') {
                    continue;
                }
                else if (param == 'filter') {
                    var offer_ids = JSON.parse(criteria[param]);

                    if (offer_ids.length > 0) {
                        q.whereIn('id', offer_ids);
                    }
                }
                else if (param == 'name' || param == 'description' || param == 'requirements') {
                    q.where(param, 'ilike', '%' + criteria[param] + '%');
                }
                else {
                    q.where(param, '=', criteria[param]);
                }
            }
        })
        .orderBy('name')
        .fetchPage({    // fetchPage    // Not working for some reason
                    page: 2,    
                    pageSize: 5,
                   withRelated: ['lists', 'brands', 'status', 'offerType', 'images'] 
        });
    }

[thebergamo]

Will be very useful if the @vellotis PR will be accepted. I’m having this problem.

[rmharrison]

fetchPage() also seems to be broken for me on bookshelf v0.9.5

Works fine:

Data.query(function(qb) {
    ...
   })
  .fetchAll()
  .then(function(model) {
    return res.json(model);
    });
})

Doesn’t work:

Data.query(function(qb) {
    ...
   })
  .fetchPage()
  .then(function(model) {
    return res.json(model);
    });
})

Only difference is fetchAll() vs. fetchPage()