Filter model based on a field from one of its relations

I must be missing something very basic, because it looks to me that this has to be a very common use case and I cannot figure out how to do it.

Let’s say I have a User and a Client models like this:

var User = bookshelf.Model.extend({
  tableName: 'users',
  client: function() {
    return this.belongsTo(Client);
  }
});

var Client = bookshelf.Model.extend({
  tableName: 'clients',
  users: function() {
    return this.hasMany(User);
  }
});

Client has a field called “is_active”. Now I want to get all users whose Client is active. Using raw knex I would do something as simple as this:

knex('users AS u') .join('clients AS c', 'c.id', 'u.client_id') .where({ 'c.is_active': true, }).then(function(users) {});

How would I do this using bookshelf? I only seem to find ways to filter the relation, but not to filter the model itself using fields from the relation.

Thanks.

[helios1138]

actually it would’ve been great to have some kind of query helper for this so you could do something like this:

Model
  .query('join', Model.related('others'))
  .where('others.is_active', true)
  .fetch()

or this:

Model
  .query(q => Model.related('others').joinTo(q))
  .where('others.is_active', true)
  .fetch()

Should be pretty straitforward since all the information is already there in .relatedData and there is no need for rewriting relation fetching itself.

[rhys-vdw]

@helios1138 is correct. Currently relations do not know how to perform joins. You’ll have to manually add a join in the query callback.

Something like this:

Model
  .query('join', 'others', 'models.id', 'others.model_id')
  .where('others.is_active', true)
  .fetch()