Process not exiting?

Hi,

I’m trying to use bookshelf.js to populate my database via a nodejs script (executed in a cronjob). However I noticed that the process doesn’t exit even after the records are successfully written to the database. Is there something I’m supposed to do to make it exit?

I’ve tried the following simple code and it doesn’t exit either:

var knex = require('knex')({
  client: 'postgresql',
  connection: {
    host     : '127.0.0.1',
    user     : 'npow',
    password : '',
    database : 'miserly',
    charset  : 'utf8'
  }
});

var bookshelf = require('bookshelf')(knex);
console.log('here');

[johanneslumpe]

How about something along these lines:

var num = 5;
var saves = [];

for (var i = 0; i < num; ++i) {
    saves.push(Store.forge({ ... }).save());
}

Promise.all(saves)
.then(function () {
    return knex.destroy();
})
.then(function () {
    console.log('all done');
});

[tgriesser]

Yeah, @carldanley just brought this up to me tonight as well, I guess this might be a good FAQ add.

But yeah, calling knex.destroy(cb) should do it. Or process.exit which isn’t as graceful but gets the job done.

The way to think about it is that opening pooled database connections is kind of like opening a new http server with .createServer… it won’t exit until you tell it to, so you should just tell it to explicitly when your script is finished.