question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

b-form-fieldset wrong class on feedback form-text div

See original GitHub issue

The feedback text in the b-form-fieldset template has class .text-muted, but really should be .form-control-feedback to visually convey the inputState, and should have an ARIA role of alert

Current template:

<template>
  <div :class="['form-group','row',inputState]">
    <label :for="target" v-if="label" :class="['col-form-label',labelLayout]" v-html="label"></label>
    <div :class="inputLayout" ref="content">
      <slot></slot>
      <div class="form-text text-muted" v-if="feedback" v-html="feedback"></div>
      <small class="form-text text-muted" v-if="description" v-html="description"></small>
    </div>
  </div>
</template>

Should be:

<template>
  <div :class="['form-group','row',inputState]">
    <label :for="target" v-if="label" :class="['col-form-label',labelLayout]" v-html="label"></label>
    <div :class="inputLayout" ref="content">
      <slot></slot>
      <div class="form-text form-control-feedback" role="alert" v-if="feedback" v-html="feedback"></div>
      <small class="form-text text-muted" v-if="description" v-html="description"></small>
    </div>
  </div>
</template>

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
tmorehousecommented, Apr 20, 2017

PR #254 created.

0reactions
tmorehousecommented, Apr 20, 2017

I’lll generate a PR

Read more comments on GitHub >

github_iconTop Results From Across the Web

Bootstrap class for not invalid-feedback - Stack Overflow
Here is one way that monitors the status of the input field and hides/shows the <small> and div.invalid-feedback elements.
Read more >
Form Group | Components - BootstrapVue
Easily add some structure to forms. Its purpose is to pair form controls with a legend or label, and to provide help text...
Read more >
Forms · Bootstrap v4.5
For invalid fields, ensure that the invalid feedback/error message is associated with the relevant form field using aria-describedby . This attribute allows ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found