DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated

Referencing collections.MutableMapping rather than collections.abc.MutableMapping triggers a deprecation warning.

>>> import botocore
>>> botocore.__version__
'1.13.15'
>>> import collections
>>> collections.MutableMapping
__main__:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

The reference occurs here: https://github.com/boto/botocore/blob/develop/botocore/awsrequest.py#L624

[swetashre]

Sorry for the late reply. We are working on a fix for it. I will update here when it will be fixed.

[clifflu]

It seems to be a different issue as I got the same Deprecation Warning from awsrequest.py:624 , not the vendored requests. botocore.version = ‘1.13.16’

Changing

class HeadersDict(collections.MutableMapping):
...

to

try:
    from collections.abc import MutableMapping
except ModuleNotFoundError:
    from collections import MutableMapping

class HeadersDict(MutableMapping):
...

fixes this warning and is pythonic IMHO. Pytest will then throw the same DeprecationWarning from session.py:947 instead.

I can create a PR for it if you like : )

Update: Should replace ModuleNotFoundError with ImportError as the former was introduced in Python 3.6, and is subclass to ImportError.