question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

KMS service definition: `SignResult` wrapper is not used

See original GitHub issue

Describe the bug The result of the sign operation is wrapped in a field called SignResult, but this is not specified as a resultWrapper in kms/2014-11-01/service-2.json:

https://github.com/boto/botocore/blob/3b7a7b329eada78d1026095a09c9928d3c491e37/botocore/data/kms/2014-11-01/service-2.json#L745-L752

Use elsewhere Amazon’s AWS SDKs have a SignResult model, taking the Android one as an example: https://github.com/aws-amplify/aws-sdk-android/blob/d4116c1909f1ecb5a31edf8588882a6181b73deb/aws-android-sdk-kms/src/main/java/com/amazonaws/services/kms/AWSKMSClient.java#L5660-L5687

This should be an easy fix, let me know if I can just open a PR for it or if there’s more that needs to be done.

Thanks!

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9

github_iconTop GitHub Comments

1reaction
zbaylincommented, Dec 16, 2021

@stobrien89 Thanks!

I actually realized that this is more broad than just Sign. I think every KMS operation is “wrapped” like this:

ListKeys:

<ListKeysResponse xmlns="https://trent.amazonaws.com/doc/2014-11-01/">
  <ListKeysResult>
    <KeyCount>1</KeyCount>
    <Keys>
      <member>
        [redacted]
      </member>
    </Keys>
    <Truncated>false</Truncated>
  </ListKeysResult>
  <ResponseMetadata>
    <RequestId>[redacted]</RequestId>
  </ResponseMetadata>
</ListKeysResponse>
0reactions
github-actions[bot]commented, Jan 4, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Sign - AWS Key Management Service
Creates a digital signature for a message or message digest by using the private key in an asymmetric signing KMS key. To verify...
Read more >
AWS SDK for C++: Aws::KMS::KMSClient Class Reference
Key Management Service (KMS) is an encryption and key management web service. ... We strongly recommend that you do not use your Amazon...
Read more >
hashicorp/go-kms-wrapping - awskms - GitHub
Wrapper represents credentials and Key information for the KMS Key used to. // encryption and decryption. type Wrapper struct {. accessKey string.
Read more >
Amazon Web Services (AWS) Key Management Service (KMS ...
Contents. Managing AWS credentials; AWS KMS Key Policy. Source IP restrictions; Using a Multi-Factor Authentication (MFA) device. Wrapper ...
Read more >
Extract AWS KMS Signature in String format - Stack Overflow
I am using AWS KMS Asymmetric keys for this. I am able to generate key and sign the document. But not able to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found