Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Django 2.x compatibility

See original GitHub issue

Hello there,

It fails on Django 2.x

Traceback (most recent call last):
  File "/home/adas/Devel/watchdog_id/watchdog_id/auth_factories/totp/tests/test_views.py", line 29, in test_get_context_data
    response = self.client.get(self.url)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/test/client.py", line 517, in get
    response = super().get(path, data=data, secure=secure, **extra)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/test/client.py", line 332, in get
    return self.generic('GET', path, secure=secure, **r)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/test/client.py", line 404, in generic
    return self.request(**r)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/test/client.py", line 485, in request
    raise exc_value
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/core/handlers/exception.py", line 35, in inner
    response = get_response(request)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/core/handlers/base.py", line 128, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3.5/contextlib.py", line 30, in inner
    return func(*args, **kwds)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/adas/Devel/watchdog_id/watchdog_id/auth_factories/totp/views.py", line 36, in dispatch
    return super(OTPPasswordCreateView, self).dispatch(request, *args, **kwargs)
  File "/home/adas/Devel/watchdog_id/watchdog_id/auth_factories/mixins.py", line 17, in dispatch
    return super(UserSessionManageMixin, self).dispatch(request, *args, **kwargs)
  File "/home/adas/.virtualenvs/watchdog_id/lib/python3.5/site-packages/braces/views/_access.py", line 98, in dispatch
    if not request.user.is_authenticated():
TypeError: 'bool' object is not callable

Django-braces version: 1.11.0

Issue Analytics

State:
Created 6 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

4reactions

PetrDlouhycommented, Jan 30, 2018

@kennethlove The branch 2.0 tests runs in all tested Django/Python versions. I have added Django 2.0 to the test mix and included a small test fix in #237. Are those backwards compatibility issues not covered by the tests?

0reactions

tungdcommented, Apr 4, 2018

@elcolie it isn’t. You’d need to upgrade to 1.12.0 (latest)