onShippingChange clarity

This is a follow up to #470

In that issue, @crookedneighbor mentioned that actions.order.patch([ would not work in the onShippingChange callback. However, with limited testing, I was able to get it to work just fine as far as representing the change within the paypal modal popup. So, I’m not sure if I’m misunderstanding here (perhaps it appears to work fine, but in some production mode, or on the braintree side, it doesn’t work?), or if there is more to understand here?

The desired use case is to have the paypal modal be able to:

• change shippingOptions based on addressChange
• change amount (total) based on selected shippingOptions due to changes in tax and shipping * charges

Is this possible?

[shawncook]

@jortizsao I have noticed the same. The following does not currently work, but here is where I’m at:

In createOrder, if I sidestep Braintree and use actions.order.create({...}) instead of instance.createPayment({...}), I’m able to load a PayPal modal with its expected functionality (including correct behavior for onShippingChange).

Next, I attempt to authorize the order, hooking into Braintree instance.tokenizePayment to obtain a payment method nonce:

onApprove = (data, actions) => {

  // Authorize or capture to obtain the order's details
  actions.order.authorize().then((authorizePayload) => {

    /**
     * The values `data.billingToken` and/or `data.​paymentID` are necessary for Braintree
     * tokenization to work as expected. Because we're using `actions.order.create`
     * from PayPal SDK v2 instead of `instance.createPayment` from Braintree and v1,
     * those values return as empty strings.
     */
    instance.tokenizePayment(data).then((tokenizePayload) => {

       // When used during `gateway.transaction.sale` in backend, the value in
       // tokenizePayload.nonce triggers "Incomplete PayPal account information" error.

    });
  });
}

Unfortunately, running gateway.transaction.sale() on the backend using the nonce generated by tokenizePayment returns an error 82901. Perhaps I need to include facilitatorAccessToken in some form.

TL;DR:

• Braintree uses Paypal Orders API v1 to perform tokenization, but actions.order.create is part of Orders API v2 (slight edit to language here)
• Using onShippingChange sorta works, but shipping won’t be added to the line item total on first modal load, and changing shipping option triggers a PATCH error.

[719media]

@crookedneighbor any updates here? It does seem very strange/unexpected/baffling that the new paypal v2 has been out for almost 4 years now, and braintree, the company we went with specifically for their first-party paypal support, still doesn’t support it. I mean no offense, I’m just surprised that this hasn’t been a higher initiative. Perhaps there are reasons that may help us understand why this continues to be backburnered? Should we look into just implementing paypal integration outside of braintree?