Improve Migration Documentation Around Browser Switch Activity

The migration guide suggests that we use our own activity rather than V3 com.braintreepayments.api.BraintreeBrowserSwitchActivity. But it is unclear what that activity is supposed to do.

MyPaymentsActivity referenced in the manifest snippet isn’t used anywhere else in the guide.

In my use case I have multiple activities that can create a paypal payment method but I am unsure on how I am supposed to handle this.

[sdoward]

@sshropshire To be clear this is not my example, this is your API. All consumers of the lib have to deal with that. If they don’t it is poor practice. It could be considered defensive programming to take care of all code paths.

This means that I want my code to work 100% of the time, I don’t want it to be “highly probable” that it works. So I need to write code to account of these states that shouldn’t happen. The only reason I have to write code for these states is because of the API design.

It is still possible to use SAM interfaces and not have this mixed up state. RxJava would be a good API to use as a reference, it’s really common that one has to receive a successful result or an error. The API looks like so…

Observable.subscribe(@NonNull Consumer<? super T> onNext, @NonNull Consumer<? super Throwable> onError)

public interface Consumer<@NonNull T> {
    void accept(T t) throws Throwable;
}

The generics make it a little more complex than what is actually necessary but you get the idea. If the RxJava devs decided to pass everything as nullable in 1 interface I don’t think it would have had the adoption that it did.

With regards to the either… They are typically complex for the author to write but pretty straight forward for the consumers to consume. You can take a look at kotlins result class for another approach to the same problem

With regards to your target audience… I am a little surprised. I guess that is a business decision but it would be interesting to see where your revenue streams come from… beginner devs or professional apps devs. It seems a little surprising that beginners to java would try and incorporate a payment system into anything they are making.

[sshropshire]

@gomera not sure exactly what we missed, but we do have an open discussion on improving the developer experience. Feel free to add input. We’re looking to improve the SDK and we welcome merchant feedback.