DeepScan & Lighthouse Tuning and Fixes

• Bug
• Clean up
• Question
• Enhancement
• Suggestion
• Other

What needs to be done.

As the app progresses and evolves, issues arise. DeepScan scores the application by the amount of warnings and errors displayed by ESLint. The goal here is to remove as many errors that appear as possible to keep the code clean and to keep the score good.

Web.dev also scores the site based on Performance, Accessibility, Best Practice, and SEO. The report for Binari.dev can be found here. If you find anything to do which can improve the scores, feel free to give it a shot and I will generate a new report to display on this issue.

How

For DeepScan

Read the warnings here or run npx eslint . to view the warnings/errors.

For Lighthouse

Follow to tips mentioned here or do what you think is best for the app.

[BrandonArmand]

@vsan626 Go ahead and create a PR with the updated .eslintrc.js file and if the warnings go away, then great! Otherwise, we can work from there and see what needs to be fixed. I was aware of the React version warning, but decided to leave it to newcomers to fix (:

In the DeepScan score found here we can also see that there are two no-console warnings that you can also fix if you would like. After that I think that Binari’s score should increase in the eyes of DeepScan; at least for now. There will definitely more warnings and errors to fix in the future as well.

Once you create a PR and will review and merge as soon as possible.

Thanks!

[BrandonArmand]

@OmarShezan I have updated the ESLint config file and fixed most of the warnings that could automatically be fixed. You should now be able to use ESLint to see most of the issues. DeepScan also runs its own rule set when merged which are un-related to ESLint which you will need to go to DeepScan to see, or install the DeepScan plugin in whatever Code Editor you are using.

As of now, all the errors/warning are related to ESLint and not DeepScan, so just calling npx eslint . should mostly do the trick.