question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Enable chromium translation engine

See original GitHub issue
  1. Add new base::Feature and flag (i.e. BraveInternalTranslate)
  2. Enable both buildflags enable_brave_translate_go and enable_brave_translate_extension
  3. Rewrite buidlflags-related code in the way that the new flag makes sense (not compile-time buidlflags).
  4. Make already installed translate extension to have a priority over internal translation
  5. Check that network requests are properly redirected to Brave backend (see)

for QA:

  1. check that a already installed google translate extension works well
  2. check that there is now conflicts between internal translation and extension-based

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
LaurenWagscommented, Dec 1, 2021

awesome, thanks @stephendonner 👍🏻

you good with the checks from https://github.com/brave/brave-browser/issues/18593#issuecomment-983207085 @rebron? I think they cover what we discussed 😄

1reaction
LaurenWagscommented, Nov 17, 2021

QA/Blocked pending more information on internal translations, etc. cc @rebron @brave/legacy_qa

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add & translate strings (aka 'Localization' or 'Translations')
Chromium uses GRIT for managing its translated strings in grd/grdp files. Base messages are written in U.S. English (en-US) and are translated into...
Read more >
Enable Translator in Microsoft Edge Chromium
To Enable Translator in Microsoft Edge Chromium, · Update your Edge Canary to version 76.0.144.0. · Type translate in the flag search box....
Read more >
Enable Translate
Setting the policy to True provides translation functionality when it's appropriate for users by showing an integrated translate toolbar in Google Chrome ...
Read more >
How can I custom the Chromium Edge built-in translator ...
However, if you want to use Google Translate, install the Google Translate Chrome Extension in the Chromium-based Edge.
Read more >
How to enable or disable translation in Chrome for Windows?
Open Chrome on your Windows PC. · Go to the menu. · Go to Settings > Advanced. · Expand the Languages heading. ·...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found