Accessibility crash while closing tabs or restoring a session
See original GitHub issueBrowser crash https://brave.sp.backtrace.io/p/brave/debug?filters=((callstack%2Ccontains%2CaccessibilityAttributedStringForRange)%2C(ver%2Cregex%2C"8[7|8|9].*")%2Cptype%3Dbrowser)&debug=(c25f28,0,0)
[ 05 ] std::__terminate(void (*)())
[ 06 ] __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*)
[ 07 ] __cxa_throw
[ 08 ] 0x7fff6ca756ed
[ 09 ] 0x7fff3625b33c
[ 10 ] -[AXPlatformNodeCocoa accessibilityAttributedStringForRange:]
Steps to Reproduce
- System preferences -> Accessibility -> Keyboard -> Enable Typing feedback
- Login to GMail, open second tab (Cmd-T) with gmail, close it (Cmd-W). Sometimes you need to open several tabs with GMail and quickly close them one by one
- Observe a crash
- Restart a browser, try to restore tabs
- Observe a crash
Reproduces how often:
Easily reproduced/Intermittent issue/No steps to reproduce
Brave version (brave://version info)
Brave | 1.19.86 Chromium: 88.0.4324.96 (Official Build) (x86_64) |
---|---|
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
OS | macOS Version 10.15.7 (Build 19H114) |
and newer, tested on
Brave | 1.21.28 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64) |
---|---|
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
OS | macOS Version 10.15.7 (Build 19H114) |
Version/Channel Information:
- Can you reproduce this issue with the current release? yes
- Can you reproduce this issue with the beta channel? yes
- Can you reproduce this issue with the nightly channel? yes
Technical notes
The crash occurs in accessibilityAttributedStringForRange
which is called by MacOS for different elements of the browser UI. For some reason, MacOS calls it for Tabs, and in this unfortunate case the requested string cannot be obtained. We have to figure out why this happens at all, because Chrome doesn’t look affected
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Restore last session, last tabs after crash - Google Support
I know how to re-open a closed tab, fcs, what I want is MY PREVIOUS SESSION). ... The restore should be based on...
Read more >How to Restore Chrome Tabs After Crash (6 Best Methods)
Another easy method is to right-click on Chrome's tabs and select the option 'Reopen Closed tab' to get back the closed tabs.
Read more >Restore previous session - Configure when Firefox shows ...
Firefox can restore all windows and tabs that were open when it was last closed or terminated unexpectedly. This article describes the circumstances...
Read more >An attempt to restore a session failed, and I lost all my tabs ...
It appears that when the browser crashed a 2nd time, it created a null / blank session, and when I attempted to restore...
Read more >How to recover saved sessions after a crash that uninstalled ...
My laptop (windows 10) crashed and said it ran into an unexpected error (which happens from time to time), only this time when...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Encountered a crash on
1.21.30
Enabled Typing Feedback in Accessibility settings (also enabled all 4 options for this):
STR:
cmd + t
and typem
immediately followed by pressingreturn
.Crash Report ID:
421a0000-9cc8-c705-0000-000000000000
Attempted to reproduce the crash with
1.21.35 CR: 88.0.4324.96
but couldn’t reproduce. After speaking with @iefremov, this could be aCatalina
vsBig Sur
issue. Going to work with @LaurenWags to see if she can reproduce as she’s on Catalina as well.If QA can’t reproduce @iefremov, we might just need to uplift and have @iefremov verify it once we uplift and get a
1.19.x
build.