Ad Block filter universal syntax broken
See original GitHub issueDescription
Until recently, excluding a domain prefix to a filter would cause that filter to be applied universally to all sites. For instance ##.foo
would block any element with a css classname of “foo” on any site. This has stopped working.
Non-universal syntax still works (prepending the filter with a domain).
Steps to Reproduce
- Manually add a custom filter via
brave://adblock/
such as##.foo
- Visit a site with an element with that class
- Element is not blocked
Actual result:
The custom filter is ignored
Expected result:
The custom filter is applied
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Brave: V1.26.77 (it was broken in the previous version too) OS: macOS 11.4 (ARM & Intel)
Version/Channel Information:
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? Maybe
- Can you reproduce this issue with the nightly channel? Maybe
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? N/A
- Does the issue resolve itself when disabling Brave Rewards? N/A
- Is the issue reproducible on the latest version of Chrome? N/A
Miscellaneous Information:
N/A
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:15
Top Results From Across the Web
AdBlock is blocking something or has broken a website (for ...
The best solution is to change the name to something the filter lists won't recognize as an ad. Ask the list authors for...
Read more >Adblock Plus filters explained
Adblock Plus filters explained. Simple blocking rules. Example 1: Blocking by address parts; Example 2: Blocking by domain name; Example 3: Blocking exact ......
Read more >How Do Ad Blockers Work? A Guide For Publishers (2022)
Ad blockers look for HTTPS requests and on-page elements; as thus, they can't block ads within audio/video streams without blocking the whole ...
Read more >adfilt/SyntaxMeaningsThatAreActuallyHumanReadable.md at ...
Main example list: uBlock Filters; AdGuard-specific syntaxes: AdGuard Base Filters ('AdGuard for Windows' version); ABP-/AdBlock-specific syntaxes: ABP Anti- ...
Read more >Ultimate Guide to Ad-Blocking Filter Lists - Comparitech
The default ABP anti-circumvention filter list is designed to block ads that use more sophisticated techniques in attempts to stop ad-blocking ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Had to use an EU VPN to see the cookiebanner in the first place, but now I see that it is indeed not hidden in
standard
Shields mode. Will work on a fix for that as well, since that’s still not intended. In the meantime, you should be able to fix it by settingTrackers & ads blocked (aggressive)
either per-site in the Shields panel or globally in brave://settings/shields.Edit: filed https://github.com/brave/brave-browser/issues/19085
Yes, at the moment 1.31.x is Nightly and 1.30.x is Beta. Our release schedule is on the wiki if you’re curious.