question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`add funds` link on tip banner yields no action - follow up to 2628

See original GitHub issue

Description

Follow up to #2628

Clicking on add funds link in site tipping banner doesn’t do anything. It should link to brave://rewards/#add-funds as the panel does.

Steps to Reproduce

  • Clean install
  • enable rewards
  • Visit site and open rewards panel
  • Click Send a tip...
  • Choose tip amount
  • Click add funds link

Actual result:

Nothing happens screen shot 2019-02-05 at 1 25 30 pm

Expected result:

Should link to brave://rewards/#add-funds screen shot 2019-02-05 at 1 27 16 pm

Reproduces how often:

easy

Brave version (brave://version info)

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
NejcZdovccommented, Feb 5, 2019

@LaurenWags so link is there and all code is correct. At some point we apparently changed permissions and brave links are blocked in webui

0reactions
LaurenWagscommented, Feb 12, 2019

Verified passed with

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux
Read more comments on GitHub >

github_iconTop Results From Across the Web

Public Law (PL) 107-314 - GovInfo
Courts-martial for the National Guard when not in Federal service. Sec. 513. Fiscal year 2003 funding for military personnel costs of reserve component ......
Read more >
Medicare Claims Processing Manual, Chapter 4 - CMS
The costs on the bill are summed to add the costs of any ... described in 42 CFR 419.43(d)(6)(ii), the time value of...
Read more >
Nvs - River Thames Conditions - Environment Agency - GOV.UK
Courier post nightlife, Not equal sign in vb net, Gasthof eisenbahn hessental, ... Augenarzt begall bewertungen, Lloyds bank interest rates savings, ...
Read more >
Text - H.R.1865 - 116th Congress (2019-2020): Further ...
The following sums in this Act are appropriated, out of any money in the Treasury not otherwise appropriated, for the fiscal year ending...
Read more >
SQL Server String or binary data would be truncated
Truncated value: '%.*ls'. The new message ID is 2628. This message replaces message 8152 in any error output if trace flag 460 is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found