Add `Keep in dock` option to first run dialog and settings
See original GitHub issueDescription
When user sets Brave as a default browser, “Keep Brave in dock” also.
Steps to Reproduce
- Launch Brave with clean profile
- Click
Set Brave as defaultbutton after checkingKeep in dock - Check Brave is added to dock
- Load brave://settings/getStarted and check settings shows as
Brave is already in dock - Unpin from taskbar and reload brave://settings/getStarted and click
Dockbutton - Check Brave is added to dock
Brave version (brave://version info)
Version/Channel Information:
- Can you reproduce this issue with the current release? n/a
- Can you reproduce this issue with the beta channel? n/a
- Can you reproduce this issue with the nightly channel? n/a
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? n/a
- Does the issue resolve itself when disabling Brave Rewards? n/a
- Is the issue reproducible on the latest version of Chrome? n/a
Miscellaneous Information:
See related: https://github.com/brave/brave-browser/issues/24054
Issue Analytics
- State:
- Created a year ago
- Comments:7 (1 by maintainers)
Top Results From Across the Web
Use the Dock on Mac - Apple Support
Control-click the app's icon, then choose Options > Keep in Dock. Rearrange items in the Dock: Drag an item to a new location....
Read more >Snagit Preferences - TechSmith
Open Snagit Preferences. Windows: Capture Preferences: In the Capture Window, select File menu > Capture Preferences. Editor Preferences: In Snagit Editor, ...
Read more >How to use System Preferences settings on a Mac - Macworld
If you want to add System Preferences to your Dock here's how: Search for it by pressing Cmd+Space and start typing System Preferences....
Read more >How to use the taskbar in Windows - Microsoft Support
Customize the taskbar from the taskbar itself. If you want to change multiple aspects of the taskbar at one time, use Taskbar settings....
Read more >23 useful Mac settings hiding in plain sight - Popular Science
Since you've been accessing many of these options through System Preferences, launching the application more easily will speed up your setting- ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

I guess
chrome/browser/mac/dock.hcan be used for thisVerification
PASSEDusingPrerequisite: make a non-Brave browser the system default via
Apple menu->System Preferences...->General->Default web browserCase 1: Pin Brave to dock via the
Pin to Dockcheckbox in the first-run dialog -PASSED1.46.96Keep in DockcheckboxSet Brave as defaultbuttonDo you want to change your default web browser to "Brave" or keep using "Firefox"?dialogUse "Brave"brave://settings/getStartedBrave is your default browsertextBrave is already in DocktextConfirmed Brave is successfully kept in the dock
Case 2: Unpin Brave from the dock and
Pin to Dockit frombrave://settings/getStarted-PASSEDCase 1, with Brave kept in the dockOptions->Keep in Dockbrave://settings/getStartedDockbutton besideKeep in Dockis clickableDockBrave is already in DockConfirmed Brave is docked and shows
Options->Keep in DockenabledCase 3: With
Pin to Dockunchecked (default), clickSet Brave as defaulton the first-run dialog -PASSED1.46.96Keep in Dockunchecked (default)Set Brave as defaultbuttonUse "Brave"on the next dialogSkip welcome tourbrave://settings/getStartedDockbutton is shown in next toKeep in DockDockbuttonDockbutton onbrave://settings/getStarteddisappearsConfirmed Brave is docked and shows
Options->Keep in DockenabledCase 4:
Pin to DockBrave viabrave://settings/getStartedwhen a non-Brave browser is set as default viaApple menu’ ->System Preferences->GeneralDefault web browser-PASSED1.46.96Maybe laterSkip welcome tourSet as defaultin the infobarUse "Brave"brave://settings/getStartedBrave is your default browserDockbutton is enabledDockbuttonDockbutton disappearedBrave is already in DockConfirmed Brave is docked and shows
Options->Keep in DockenabledCase 5: Upgrade from
1.45.100 (beta)->1.46.96 (beta)-PASSED1.45.100Set Brave as defaulton the first-run dialogUse "Brave"brave://settings/getStartedand confirmed it showsBrave is your default browser text1.46.96brave://settings/getStartedDockbuttonDockbutton disappeared, and the text now reads "Brave is already in Dock`Confirmed Brave is docked and shows
Options->Keep in Dockenabled