question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add missing collapse/expand arrows for bookmark folders in Sidebar

See original GitHub issue

Description

Add missing collapse/expand arrows for bookmark folders in Sidebar

Steps to Reproduce

  1. install latest nightly
  2. launch Brave
  3. import https://github.com/brave/qa-resources/blob/master/brave_sorted_1000.html
  4. click on the Bookmarks icon in the Sidebar
  5. look at the nested folders

Actual result:

Nested folders are missing the collapse/expand arrows

Screen Shot 2022-03-04 at 6 52 42 PM

Expected result:

Compare with the native Bookmarks view

Screen Shot 2022-03-04 at 9 52 48 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.23 Chromium: 99.0.4844.51 (Official Build) nightly (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)

cc @simonhong @rebron

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
aguscruizcommented, Mar 8, 2022

@simonhong can we just reuse the bookmark manager’s styles, icons and sizes for the sidebar view?

Let me know if you need more specifics, but basically so they both look the same.

0reactions
stephendonnercommented, Nov 1, 2022

Closing as stale. @stephendonner I believe we addressed this issue before releasing bookmarks sidebar panel.

Yup, looks good to me with

Brave 1.47.33 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

The “twisties” – expand/collapse arrows – are back:

Screen Shot 2022-11-01 at 9 53 26 AM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Removing arrows from bookmark folders | Firefox Support Forum
Chosen solution. If you have CTR then try to add the code via CTR (Custom ccs code) instead of using userChrome.css.
Read more >
Why the heck are bookmarks in the safari sidebar auto ...
Every time I go to open the sidebar, it seems like the "bookmarks" section is auto-collapsed. Annoyingly I have to re-expand it EVERY...
Read more >
Sidebar Features - ClickUp Help
Collapse and expand the Sidebar. Simply click the arrow on the top right corner of the Sidebar. You can also press Q on...
Read more >
How to restore missing expansion triangles in the Finder
—the Finder breaks up the display into subheads using the category your selected, and the expansion/collapse triangles disappear. Then Sort By ...
Read more >
Use sidebars in Pages on Mac - Apple Support
Right sidebar: Click Format or Document in the toolbar to open the sidebar and show the controls. To close the sidebar, click the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found