Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add option to context-click remove Brave Rewards (BAT) icon

See original GitHub issue

Description

No option to context-click remove Brave Rewards (BAT) icon, unlike Wallet and VPN icons

Steps to Reproduce

install 1.40.5
launch Brave
context-click on the Rewards (BAT) icon in the URL bar
context-click on the Wallet icon in the browser toolbar
enable VPN and SKUs SDKs via brave://flags
click on Relaunch to restart Brave
context-click on the VPN icon in the browser toolbar

Actual result:

We provide the ability to remove the Wallet and VPN icons via context-clicks, but not the Rewards/BAT icon.

Expected result:

Consistency - note you can remove it via Show Brave Rewards icon in address bar in brave://settings/appearance.

Also note the text differences already, in https://github.com/brave/brave-browser/issues/22436.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.40.5 Chromium: 101.0.4951.41 (Official Build) nightly (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Windows 10 Version 21H2 (Build 19044.1645)

cc @rebron @Miyayes @bsclifton

Issue Analytics

State:
Created a year ago
Comments:6 (1 by maintainers)

Top GitHub Comments

2reactions

mkarolincommented, May 16, 2022

QA Plan:

Launch Brave
context-click on the Rewards (BAT) icon in the URL bar

Expected result: Observe context menu with the option to hide the icon

Click on the menu option to hide the rewards icon

Expected result: Rewards icon is no longer shown in the URL bar

Navigate to brave://settings/appearance

Expected result: Confirm that Show Brave Rewards icon in address bar setting is OFF

Toggle Show Brave Rewards icon in address bar setting to ON

Expected result: Rewards icon is shown in the URL bar

1reaction

mkarolincommented, Apr 27, 2022

I looked back at the history here. We added a toggle in the settings to hide the icon in https://github.com/brave/brave-browser/issues/2975, but it was - at the time - limited to when Rewards was disabled (when we had a Rewards on/off switch). When we removed the Rewards on/off switch in https://github.com/brave/brave-browser/issues/11467 we also adjusted the toggle to always be able to hide the icon. Since we already have a way to hide it, there’s no counterindication, IMO, to adding a way to do it via the context menu.

Top Results From Across the Web

BpV - ALBA.Net

Evropa2 ibiza mp3, Novel brave new world summary, Pickle append python, 1970 nfl draft ... Clear auto type iphone, Cinti collezione primavera estate...

ESPDIC Esperanto-English Dictionary (utf-8 text file)

Bravo! braveco : bravery, valor bravega : very brave bravegeco : temerity ... parade defingrigi : to remove sth from one's finger definitiva...

MOOSE Crossing: Construction, Community, and Learning in ...

Michael Maier made the nifty moose icon used on the. MacMOOSE application and other parts of the MOOSE. Crossing project.

Esperanto–English dictionary

The 30 000 most-used Esperanto words, defined on one page.

The Legend of Zelda: Four Swords Adventures - GameCube

The Item Levels are a new idea, but that is rare, and items come and ... Kill the bats and wait for the...