question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add Site should probably read Add site in new-tab page's Favorites

See original GitHub issue

Description

Add Site should probably read Add site in new-tab page’s Favorites

Steps to Reproduce

  1. open the new-tab page
  2. click Customize
  3. choose Top Sites from the left
  4. choose Favorites
  5. dismiss the dialog
  6. hover to the right of the Add site button
  7. click on the ellipsis
  8. note the capitalization of Add Site

Actual result:

It reads Add Site (upper-case)

Screen Shot 2021-03-09 at 11 14 11 AM

Expected result:

Add site (lower-case)

Reproduces how often:

Brave version (brave://version info)

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5

github_iconTop GitHub Comments

1reaction
akshat-rawatcommented, Jul 1, 2021

@stephendonner, I have made the necessary changes and opened a PR for the same.

0reactions
stephendonnercommented, Jul 6, 2021

Verified FIXED using the inline testplan with build

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. open the new-tab page
  2. click Customize
  3. choose Top Sites from the left
  4. choose Favorites
  5. dismiss the dialog
  6. hover to the right of the Add site button
  7. click on the ellipsis ...

Confirmed it now reads Add site

Screen Shot 2021-07-06 at 4 47 24 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

I can't add favorite sites on my new tab - Brave Community
I read the support site, I unistalled and installed the browser, I just recently installed this browser and this became a problem.
Read more >
How to Customize Chrome's New Browser Tab for Productivity ...
Go back to the tab with the customization page, and in the Edit Shortcut window, type the name of the website, and paste...
Read more >
Be able to edit and add "top sites" shown on the Dashboard ...
This new tab plugin has some killer features along these lines. Editable favorites, adjustable rows, columns. Folders for favorites and pages ...
Read more >
9 Ways to Customise the New Tab Page in Chrome
Chrome's new tab page is serviceable, but a bit boring. ... You're free to customize the colors, but you can't add links to...
Read more >
Favorites - New Tab Page
Favorites – a new tab page with your favorite bookmarks • Add and rearrange bookmarks via drag and drop • Customize the layout...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found