Adding "Never Ask Again" under Google Translate popup
See original GitHub issueDescription
When we released the Google Translate popup feature in 0.69.x
via https://github.com/brave/brave-browser/issues/5561, it made using Brave more inconvenient for none-english peaking users as they constantly get the popup when visiting English websites. Some examples of user concerns: https://github.com/brave/brave-browser/issues/6326, https://github.com/brave/brave-browser/issues/6329, https://github.com/brave/brave-browser/issues/208#issuecomment-538279280, https://github.com/brave/brave-browser/issues/208#issuecomment-538537499.
We should add a Never ask again
or a Don't ask again
checkbox under the prompt that would control the Offer to translate pages that aren't in a language you read
setting via brave://settings/languages
.
Steps to Reproduce
- install and launch
0.69.132 Chromium: 77.0.3865.90
- depending on your locale, visit a website that’s in a different language so you get the Google Translate prompt.
Actual result:
Expected result:
Should be similar to what we implemented with Widevine. Example:
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Brave | 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit) |
---|---|
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830} |
OS | macOS Version 10.14.6 (Build 18G95) |
Version/Channel Information:
- Can you reproduce this issue with the current release?
Yes
- Can you reproduce this issue with the beta channel?
Yes
- Can you reproduce this issue with the dev channel?
Yes
- Can you reproduce this issue with the nightly channel?
Yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
N/A
- Does the issue resolve itself when disabling Brave Rewards?
N/A
- Is the issue reproducible on the latest version of Chrome?
N/A
Miscellaneous Information:
CCing @rebron @bsclifton @bbondy @davidtemkin @yrliou @brave/legacy_qa
Issue Analytics
- State:
- Created 4 years ago
- Reactions:7
- Comments:5 (1 by maintainers)
Top GitHub Comments
How about this:
@bradleyrichter @karenkliu Do we even need a mock? I think we can simply go with the: [ ] Don’t ask again check box like what @kjozwiak linked to above.