question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Adding "Never Ask Again" under Google Translate popup

See original GitHub issue

Description

When we released the Google Translate popup feature in 0.69.x via https://github.com/brave/brave-browser/issues/5561, it made using Brave more inconvenient for none-english peaking users as they constantly get the popup when visiting English websites. Some examples of user concerns: https://github.com/brave/brave-browser/issues/6326, https://github.com/brave/brave-browser/issues/6329, https://github.com/brave/brave-browser/issues/208#issuecomment-538279280, https://github.com/brave/brave-browser/issues/208#issuecomment-538537499.

We should add a Never ask again or a Don't ask again checkbox under the prompt that would control the Offer to translate pages that aren't in a language you read setting via brave://settings/languages.

Steps to Reproduce

  1. install and launch 0.69.132 Chromium: 77.0.3865.90
  2. depending on your locale, visit a website that’s in a different language so you get the Google Translate prompt.

Actual result:

Screen Shot 2019-10-07 at 1 06 18 PM

Expected result:

Should be similar to what we implemented with Widevine. Example:

Screen Shot 2019-10-07 at 12 38 27 AM

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @bbondy @davidtemkin @yrliou @brave/legacy_qa

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:7
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

12reactions
karenkliucommented, Oct 7, 2019

How about this:

install google translate

1reaction
rebroncommented, Oct 7, 2019

@bradleyrichter @karenkliu Do we even need a mock? I think we can simply go with the: [ ] Don’t ask again check box like what @kjozwiak linked to above.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Change Chrome languages & translate webpages - Android
On your Android phone or tablet, open the Chrome app Chrome . To the right of the address bar, tap More More and...
Read more >
Chrome Disable "Translate This Page?" pop-up, but keep ...
Under "Languages," click Language. Check or uncheck "Offer to translate pages that aren't in a language you read."
Read more >
How to enable and disable Translation bar in Google ...
Learn the steps for enabling and disabling the Translation bar of Google ™ Chrome in your Windows® 7 based PC.Content in this video...
Read more >
How to enable/disable google translate inside any app
Open the Google Translate app. -At the top left, tap Menu and then Settings. -Click on Tap to Translate. -Check to Enable or...
Read more >
How to Turn Translation On or Off in Chrome - How-To Geek
From here, you can choose to “Show Original” to translate the page back into the original language, or you can click the dropdown...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found