Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

adding recurring date within the tip table under brave://rewards

See original GitHub issue

Description

We should display the recurring date within the Tip table under brave://rewards. Once a user sets a recurring tip and forgets the date, there’s no visible way to check via the current UI.

Steps to Reproduce

launch the most recent version of brave (0.55.20 Chromium: 70.0.3538.67 in this case)
enable rewards via brave://rewards & accept a grant
visit a any website and click on the BAT icon under the URL
click on Send tip..
select an amount and enable Make this monthly and click on Set monthly Tip
visit brave://rewards and you’ll see the entry but there’s no visible recurring date

Actual result:

Expected result:

We should display the recurring date within the table. Once a user sets a recurring tip and forgets the date, there’s no visible way to check via the current UI.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave	0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Mac OS X

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under both dev and beta as well.

Additional Information

CCing @jenn-rhim

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

davidtemkincommented, Jan 19, 2019

Let’s do it. Add a line to the Tips panel, as follows:

“Monthly tips will next be sent” followed by the next contribution date.

The formatting should match the line in the A-C panel (“next contribution date”).

NOTE : This line should only appear if the user has established one or more monthly tips. In the event that there are no active monthly tips, the line should not appear.

0reactions

LaurenWagscommented, Feb 12, 2019

Verified passed with

Brave	0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

Verified test plan from https://github.com/brave/brave-core/pull/1412
Verified if there are no recurring tips, the contribution line is not displayed:
Verified when there is at least one recurring tip the contribution line is displayed:
Verified that if only one recurring tip is listed and you remove it, the contribution date line is removed from view
Verified that once monthly recurring tips contribute, the date in this panel is updated (note, screenshots below are from a different profile than the one used above that’s why the ‘Total tips this month’ value is different):
Logged follow up issue for text https://github.com/brave/brave-browser/issues/3287