Ads history will not be shown at all if there is an ad older than 7 days

Found when testing https://github.com/brave/brave-browser/issues/5863 We show 7 day ads history, if there is an ad older than 7 days, the whole ads history will not be shown. This is a regression in 1.3.x.

Important: This issue is not reproducible on 1.2.x, 1.4.x, 1.5.x Important: Talked to @tmancey, and he said that this issue is fixed by https://github.com/brave/brave-browser/issues/6757

Steps to Reproduce

1. Clean install
2. Enable rewards
3. Open brave://rewards
4. Close Brave
5. Copy generated ads history file to User Data\Default\ads_service\ (ask @btlechowski for the file)
6. Launch Brave
7. Reload brave://rewards few times

Actual result:

7-day Ads History link is not shown at all on brave://rewards

Expected result:

7-day Ads History link is shown

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproducible on

Brave	1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 7 Service Pack 1 (Build 7601.24530)

Not reproducible on

Brave	1.5.36 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 7 Service Pack 1 (Build 7601.24530)

Brave	1.4.60 Chromium: 79.0.3945.117 (Official Build) dev (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 7 Service Pack 1 (Build 7601.24530)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel? no
• Can you reproduce this issue with the nightly channel? no

cc @brave/legacy_qa @rebron @tmancey @NejcZdovc

[btlechowski]

The issue only reproduces on 1.3.x.

I still see duplicate uuid in the new client.json

This is the file I use when the issue reproduces: client.zip The file contains 8 ads, an ad is shown each day. If I delete Test Ad 001 (ad from 8th day), the history is shown

[btlechowski]

@tmancey I think the client.json you provided will always be a false-positive as the oldest ad shares the uuid with other ad and therefor will never be shown.