question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

After excluding a site from A-C table `Show All` link is not shown in ac table

See original GitHub issue

Description

After excluding a site from A-C table Show All link is not shown

Steps to Reproduce

  1. Clean profile 1.3.97
  2. Enable rewards
  3. Add a site to a-c table
  4. Exclude the added site by clicking on Trash icon
  5. After excluding a site from A-C table Show All link is not shown

Actual result:

After excluding a site from A-C table Show All link is not shown in ac table Show all link missing

Expected result:

After excluding a site from A-C table Show All link should be shown in a-c table

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
btlechowskicommented, Jan 24, 2020

This issue is not reproducible on 1.5.57 on Windows 7 x64 and Windows 10 x64

image

Brave 1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.57 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909

We should retest when https://github.com/brave/brave-core/pull/4372 and https://github.com/brave/brave-core/pull/4399 are uplifted.

0reactions
GeetaSarvadnyacommented, Feb 5, 2020

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)
Read more comments on GitHub >

github_iconTop Results From Across the Web

Apply a filter to view select records in an Access database
Open a table, query, form, or report in any of the following views: Datasheet, Form, Report, or Layout. · Make sure that the...
Read more >
Mapping to the Display, Facets, and Search Sections in the ...
The following table shows how UNIMARC fields are mapped to the fields under the Facets section in Primo VE. Out-of-the-box, all the facets...
Read more >
MySQL Select all columns from one table and some from ...
Just use the table name: SELECT myTable.*, otherTable.foo, otherTable.bar... That would select all columns from myTable and columns foo and bar from ...
Read more >
Package 'data.table' - R Project
Convert all character columns to factors? x. A data.table. i. Integer, logical or character vector, single column numeric matrix, expression.
Read more >
Metals/Nonmetals - The Parts of the Periodic Table
Nonmetals are (usually) poor conductors of heat and electricity, and are not malleable or ductile; many of the elemental nonmetals are gases at...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found