"Allow contribution to videos" controls all media publishers, not just videos
See original GitHub issueDescription
Unchecking “Allow contribution to videos” in AC settings keeps any media publisher (Twitter, Reddit, GitHub, Vimeo, Twitch, YouTube) from being added to auto contribute list.
Not sure if this is expected with new greaselion implementation. Prior to greaselion, GitHub was added to the list even if this was unchecked (fixed with https://github.com/brave/brave-browser/issues/10546). So at the very least, this is a regression for GH.
Found while testing https://github.com/brave/brave-browser/issues/12107 and using component version 1.0.40.
Steps to Reproduce
- Clean install 1.19.x (launched with
/Applications/Brave\ Browser\ Dev.app/Contents/MacOS/Brave\ Browser\ Dev --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --rewards=staging=true,reconcile-interval=5 --use-dev-goupdater-url
- Click on BAT logo and “Start using Brave Rewards”
- Open brave://rewards and open AC settings
- Uncheck “Allow contribution to videos”
- Restart browser (needed per https://github.com/brave/brave-browser/issues/13391)
- Visit a page like github.com/laurenwags for at least 30s
- Open brave://rewards
- GitHub page is not listed in AC list.
- Repeat for other media publisher types
Actual result:
No media publishers added to AC list
Expected result:
Non-video media publishers (GitHub, Reddit, Twitter) to be added to AC list, video media publishers (YouTube, Twitch, Vimeo) not added to AC list
Reproduces how often:
easily
Brave version (brave://version info)
Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (x86_64) |
---|---|
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807} |
OS | macOS Version 10.15.7 (Build 19H15) |
Version/Channel Information:
- Can you reproduce this issue with the current release? n/a for 1.18.x
- Can you reproduce this issue with the beta channel? yes 1.19.x
- Can you reproduce this issue with the nightly channel? yes 1.20.x
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? n/a
- Does the issue resolve itself when disabling Brave Rewards? n/a
- Is the issue reproducible on the latest version of Chrome? n/a
Miscellaneous Information:
Issue Analytics
- State:
- Created 3 years ago
- Comments:7 (4 by maintainers)
Top Results From Across the Web
Video publisher policy - Google Ad Manager Help
Publishers cannot use interactive media ads products to monetize YouTube-hosted content. For YouTube content, publishers must monetize through the YouTube ...
Read more >Section 230 of the Communications Decency Act
This legal and policy framework has allowed for YouTube and Vimeo users to upload their own videos, Amazon and Yelp to offer countless...
Read more >Autoplay policy in Chrome - Chrome Developers
The Autoplay Policy launched in Chrome 66 for audio and video elements and is effectively blocking roughly half of unwanted media autoplays ...
Read more >Media Studio Monetization - Twitter Help Center
Enable the Monetize all new videos with Amplify Pre-roll if you would like all newly-uploaded videos monetized automatically. Select a relevant content category ......
Read more >All Too Easy: Spreading Information Through Social Media
This was also the place to post pictures, songs, videos and was digital ... Social media has allowed thousands of people, if not...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@Miyayes works for me! just wanted to open dialog so a decision was considered from various angles. Thank you!
Thanks. If I had to choose, I would remove those video publishers completely from A-C.
I can imagine scenario (A) occurring much more than (B), and (A) arousing much more anger:
Scenario (A): “I disallowed ‘contributions to videos’, yet I’m still seeing contributions to all these YouTubers! Why are you not respecting my choices?”
Scenario (B): “I disallowed ‘contributions to videos’, but I still want to donate to my YouTubers when I’m sitting on their pages but not watching their videos. Why won’t A-C let me do that?!”
Intuitively, I think users who really wanted to support their YouTubers despite disabling “allow contributions to videos” would just do it through tipping. Moreover, (A) results in unexpected loss of BAT (which is the most aggravating situation for users), whereas (B) would never lead to unexpected loss. (B) at most would lead to unexpected keeping of BAT!
So,「remove those video platforms completely from A-C when ‘allow contribution to videos’ is disabled」would be my decision.
Let me know if you see any obvious gaps in my reasoning!