Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Amazon-cleaned URLs aren't actually cleaned of query params/strings

See original GitHub issue

Description

Amazon-cleaned URLs aren’t actually cleaned of query params/strings

Spun off from https://github.com/brave/brave-browser/issues/23315.

Steps to Reproduce

install 1.45.87
launch Brave
load https://www.amazon.com/Echo-Dot/dp/B07FZ8S74R/ref=sr_1_1?crid=1JM4ODN4MKLZO&keywords=alexa+echo&qid=1654644603&sprefix=alexa%2Caps%2C136&sr=8-1
either context-click in the URL bar or click on the Share this page icon in the URL bar
choose Copy clean link (only main URL)
paste and look at the link

Actual result:

“Cleaned” URL still is: https://www.amazon.com/Echo-Dot/dp/B07FZ8S74R/ref=sr_1_1?crid=1JM4ODN4MKLZO&keywords=alexa+echo&qid=1654644603&sprefix=alexa%2Caps%2C136&sr=8-1

Expected result:

Cleaned URL should be: https://www.amazon.com/dp/B07FZ8S74R/

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (x86_64)
Revision	fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS	macOS Version 11.7 (Build 20G817)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

cc @fmarier @spylogsster

Issue Analytics

State:
Created a year ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

fmariercommented, Oct 13, 2022

Apologies @stephendonner for not updating the original issue to make the current coverage clear. In the initial list, we added the Google utm_* parameters and then two Twitter-specific ones. Those should work fine. At the moment, there are no rules for cleaning Amazon URLs and so the expected “clean” URL is the original URL.

We should add rules to clean the Amazon params that we can, but it’s not a bug in this feature, rather it’s an example of something that’s missing in our list.

0reactions

fmariercommented, Oct 13, 2022

We didn’t include Amazon in the first release of the list, but we can add it anytime. The list we use is in https://github.com/brave/adblock-lists/blob/master/brave-lists/clean-urls.json

@ryanbr Should we just copy the Adguard Amazon rules?

Top Results From Across the Web

Caching content based on query string parameters

Describes how CloudFront forwards, caches, and logs query string parameters to your origin.

What's the best way to return a clean URL by removing ...

I'm assuming that any other query params should be left that aren't listed below since they're not defaults. searchCategoryId=all selectedFilter ...

Firefox 102: Query Parameter Stripping improves privacy

Some sites and services add tracking parameters to links to track users across sites. Facebook, for example, appends a unique fbclid string to ......

CleanURLs built into Brave shields - New Feature Feedback

ClearURLs also removes those pesky tracking parameters (utm_* for Google, fbclid for Facebook, Amazon, and so on).

What Are Query Strings & Parameters - How to Optimize

Yep, there may be query and path parameters within the URL. Each holds a different position and performs separate functions. Path Parameters. Positioned...