question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Android] Text on Brave Desktop info card looks like link

See original GitHub issue

Description

Text on Brave Desktop info card looks like link

Steps to reproduce

  1. Follow steps from https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/Mobile-onboarding-v2?node-id=697%3A5848

Actual result

brave.com on the message looks like a link. image

Expected result

Should probably have a different colour to make it obvious that its not a link and can’t be tapped

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? NA

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version:10

Brave version

1.14.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
deeppandyacommented, Aug 27, 2020

Implementation matches spec. @jamesmudgett @karenkliu should anything be done to make brave.com not look like a link? or close as wontfix?

@bsclifton i have removed brave.com as link because it’s not doing anything on tap. https://github.com/brave/brave-core/pull/6517

0reactions
srirambvcommented, Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83

  • Verified text on cross-platform promotion doesn’t look like a link

Verification passed on OnePlus 6T with Android 10 running 1.13.83

  • Verified text on cross-platform promotion doesn’t look like a link
Read more comments on GitHub >

github_iconTop Results From Across the Web

About the Desktop Support category - Brave Community
New Brave Browser for desktop does not install ... Im not instal in android ... Text in Tabs & toolbar to small like...
Read more >
[Android] Sending link from Android to Desktop doesn't work
Does the issue resolve itself when disabling Brave Rewards? Is the issue reproducible on the latest version of Chrome? Additional information.
Read more >
How to create web apps for the Brave browser | TechRepublic
Running a website as an app is a great way to make your life a bit more efficient–this is especially true when you're...
Read more >
Should you switch to the Brave Web Browser?
The problem is Ad Tracking. Brave Browser on Android phone 1. Edgar Cervantes / Android Authority. Most browsers do ...
Read more >
Stop Trackers Dead: The Best Private Browsers for 2022
Brave is a browser with an emphasis on privacy and ad-blocking, but at the same time, ... Platforms: Android, iOS, extension for desktop...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found