Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Attribution for Will Christiansen background image(s) link is broken

See original GitHub issue

Test plan

Refresh NTP until photo is The photo Glacier Peak
Click website link in attribution
It should work

Description

The photo Glacier Peak came up and I clicked on the attribution but it brought me to chrome://newtab/www.theskyfolk.com instead of the correct URL.

It looks like the background.ts link field needs to include https:// at the beginning of the link address, else it will prepend chrome://newtab to the beginning, sending users to the wrong location.

Image 14 also would require the complete link, in addition to image 13.

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

mbacchicommented, Mar 27, 2020

@kjozwiak I opened a PR (5068) to fix this but the test-install steps failed on mac/windows. I’m going to restart the pr builder and see if it works today.

0reactions

LaurenWagscommented, Mar 30, 2020

Verified passed with

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from description
Also verified for this image from Will Christiansen

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from description

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

Verified test plan from description

Top Results From Across the Web

How to fix CSS background-image not working | HTML/CSS

Working with background images in CSS can be tricky. ... Check that your CSS file is linked correctly in your HTML file.

How To Correctly Attribute Creative Commons Images - Pixsy

To make sure images are correctly attributed, include the following details and make sure they are clearly displayed by the relevant image (ideally...

background-image - CSS: Cascading Style Sheets | MDN

The background-image CSS property sets one or more background images on an element.

Attribution-NonCommercial-NoDerivatives 4.0 International (CC BY ...

Analyses using Landsat 7 ETM+ and Terra ASTER images from 2001 to 13 and ICESat ... The background image is a 28 December...

Image Copyright on Social Media: Everything You Need to Know

Remember, any license that includes the word “attribution” means that you must give credit to the creator. What images can you legally use...