Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BAP modal issues

See original GitHub issue

Description

Found while testing https://github.com/brave/brave-browser/issues/13798

Two issues found with the BAP modal (not tooltip)

unable to scroll BAP modal when in landscape mode (possibly only show modal in portrait mode --> https://bravesoftware.slack.com/archives/C0816QH3R/p1613161177249100?thread_ts=1613160945.247600&cid=C0816QH3R)
Styling of the modal looks a bit odd (large white bar at the top which is not in original issue design)

Steps to reproduce

Set device to Japan/Japanese
Install 1.22.22 Nightly, enable staging env for Rewards
Relaunch
Tap on Rewards icon, dismiss onboarding
Claim UGP grant
Close app
Advance date by 3 days
Orient device to be landscape
Launch Nightly
On tooltip, tap Learn More

Actual result

Modal is displayed, can’t scroll modal-landscape

Expected result

Able to scroll in modal (if we keep it in this view). Layout should more closely match original in https://github.com/brave/brave-browser/issues/13798#issue-795249774

Issue reproduces how often

easily

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? n/a
Can you reproduce this issue with the current Play Store Beta version? n/a
Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

Install type (ARM, x86): ARM
Device type (Phone, Tablet, Phablet): phone
Android version: 5.1

Brave version

1.22.22

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

cc @deeppandya @codybanxs @Miyayes @brave/legacy_qa

Issue Analytics

State:
Created 3 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

kjozwiakcommented, Feb 15, 2021

@Miyayes @deeppandya assuming we want this in 1.20.x for the BAP release so I moved it into https://github.com/brave/brave-browser/milestone/173 and labelling it as a release/blocking. If we don’t care about getting this into the 1.20.x - Release #2 and are fine with this going into 1.21.x, please remove it from the millstone. CCing @bsclifton @rebron

0reactions

srirambvcommented, Mar 11, 2021

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

Verified browser orientation is force changed to portrait when the modal is shown

https://user-images.githubusercontent.com/17010094/110787931-dc0bca00-8265-11eb-856f-371ab17b5d64.mp4

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

Verified browser orientation is force changed to portrait when the modal is shown

https://user-images.githubusercontent.com/17010094/110788001-f3e34e00-8265-11eb-84bf-e28da6926e97.mp4

Top Results From Across the Web

Missing translations for BAP deprecation tooltip and modal · Issue ...

Description #14117 fixed translations on desktop. We need the same translations for Android as well. Steps to reproduce Install 1.20.104 in Japanese locale ......

The difficulty in interpreting gene expression profiling in BAP ...

Conclusions. BAP-negative melanocytic tumors remain a diagnostic dilemma for dermatopathologists. A widely marketed 23-GEP test may not be ...

BAP complains to PM Imran Khan for not resolving issues

ISLAMABAD: PTI ally BAP has complained to Prime Minister Imran Khan for not resolving Balochistan's problems since he came to power three ...

(PDF) The Body Action and Posture Coding System (BAP)

We discuss issues for further validation and propose some research applications. KeywordsBody movement–Expression–Coding–Method–Emotion.

FIRST-ORDER MODAL LOGIC - UCI Canvas

Classically, first-order issues like constant and function symbols, equality, quantification, and definite descriptions, have straightforward formal treat-.