Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BR panel keeps showing `1` notification message even when rewards is not turned on

See original GitHub issue

Description

BR panel keeps showing 1 notification message even when rewards is not turned on

Steps to Reproduce

Clean profile on Linux
BR panel shows 1 notification
Click on BR panel, notification goes away
Click on BR panel again notification comes back

Actual result:

BR panel keeps showing 1 notification message even when rewards is not turned on

Expected result:

Should not show 1 notification message when rewards is turned off

Reproduces how often:

Easy on Linux

Brave version (brave://version info)

Brave	0.60.13 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision	98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS	Linux

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds? Yes on Dev build

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
Is the issue reproducible on the latest version of Chrome?

Additional Information

@brave/legacy_qa to verify on other platforms @NejcZdovc

Issue Analytics

State:
Created 5 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

NejcZdovccommented, Jan 29, 2019

reproduced on macOS and it’s a regression from this PR https://github.com/brave/brave-core/pull/1409, so we need this fix in 0.60

cc @kjozwiak @rebron

0reactions

LaurenWagscommented, Feb 13, 2019

Verified passed with

Brave	0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

Verified test plan from https://github.com/brave/brave-core/pull/1486
Verified that if you don’t click on the panel, navigate to brave://rewards and enable Rewards, the 1 notification goes away as well.

Verification passed on

Brave	0.60.23 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Windows 10

Verified test plan from https://github.com/brave/brave-core/pull/1486

Verified 1 notification is gone from BAT logo when rewards is enabled through welcome screen
Verified 1 notification is gone from BAT logo when rewards is enabled through Hamburger menu,

Verification passed on