question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Brave cloud print message needs to be removed Follow up to #1279

See original GitHub issue

Description

Brave cloud print message needs to be removed from Print dialogue

Steps to Reproduce

  1. Open any page and press <kbd>Ctrl</kbd>+<kbd>P</kbd>
  2. Brings up the print dialogue
  3. Click on Change to select available printers
  4. Device page shows Cloud print and has a sign in button which tries to connect to no-thanks.invalid

Actual result:

cloudprint

Expected result:

Should remove the entire bottom div which contains that message

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
petemillcommented, Oct 12, 2018

Confirmed that we want to remove the signed-in state feature too: Removing the dropdown and label. Should add a test plan for this state:

  • Sign in to google
  • Visit print preview
  • Change printer
  • Confirm signed-in google accounts do not show in a list
0reactions
srirambvcommented, Oct 17, 2018

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified Cloud print message is not shown when user is not signed into any Google service in a tab image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
Read more comments on GitHub >

github_iconTop Results From Across the Web

Printing through Google Cloud Print - Desktop Support
Description of the issue: You can't print through Google Cloud Print in Brave Steps to Reproduce (add as many as necessary):.
Read more >
Fix problems with Google Cloud Print - Pixel Slate Help
If your printer doesn't say it's Cloud ready, follow the steps below. Turn on your printer. On your device, open Chrome. At the...
Read more >
https://www.ala.org/rusa/sites/ala.org.rusa/files/...
Northfield Mount Hermon School has moved to a Learning Commons model. ... An expert on grief loss and trauma, following Hurricane Katrina first...
Read more >
NHS Student Handbook 21-22 pdf - Noblesville Schools
School Trustees authorizes the following actions and policies. Removal from class. A teacher may remove a student from class for a period of...
Read more >
List of Titles for State Law - Shelby County Schools
1279, The construction worker ... 1313, Courage has no color : the true story of the Triple Nickles ... 1404, A day in...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found