Brave News toolbar / Settings header isn't cleared on tab-overview page
See original GitHub issueDescription
Brave News toolbar / Settings header isn’t cleared on tab-overview page
Steps to reproduce
- install
1.37.5
- launch Brave
- tap through onboarding
- tap on the 3-dots menu on the bottom toolbar
- tap
Settings
- tap
Appearance
- tap to set
Enable Tab Groups
toOff
- tap
RELAUNCH NOW
- swipe down
- tap to
Show Brave News
- open a bunch of new-tab pages
- ensure you see the
Brave News
header w/Settings
icon in at least one of the tabs - add 2 or 3 more tabs
- now click on the tab-count eg
[11]
icon - close all the tabs
Actual result
example | example | example |
---|---|---|
https://user-images.githubusercontent.com/387249/151514086-81e0a165-269e-4ff9-848c-70ab3e2ae6e4.mp4
Expected result
The Brave News
toolbar header shouldn’t persist in the tab-overview view
Issue reproduces how often
100%
Version/Channel Information:
- Can you reproduce this issue with the current Play Store version?
- Can you reproduce this issue with the current Play Store Beta version?
- Can you reproduce this issue with the current Play Store Nightly version?
Device details
- Install type (ARM, x86):
arm64
- Device type (Phone, Tablet, Phablet):
Google Pixel XL
phone - Android version:
9.0
Brave version
1.37.5, Chromium 98.0.4758.74
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Brave News setting bar is not shown on the tab when loading ...
Enable News · Scroll down and load an article · Click on the home button and scroll down the feed, settings bar is...
Read more >How to configure Brave UI, tabs - Desktop Support
On “Search” field type “scrollabe tabstrip.” Select the option “tabs don't shrink” or whatever suits you. Relaunch Brave. Profit.
Read more >Images not displayed in Brave news - Mobile Support
On your extensions toolbar, right-click the extension you would like to remove. Select Remove from Brave… from the context menu. Additionally, ...
Read more >Toolbar disappearance on page loading - Brave Community
The toolbar is great! But it should only be there on opening a new tab. Then, it should disappear, when a site is...
Read more >Too much memory used - Desktop Support - Brave Community
Too much memory used · Activity Monitor, select the Memory tab (in the toolbar area), and select Shared Memory among the column header...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
This seems fixed on nightly. @stephendonner mind re-testing this one and close it out
cc: @alexsafe
Verified
PASSED
using1.36.99
,Chromium 98.0.4758.102
on aGoogle Pixel XL
(arm64
) runningAndroid 9.0
.https://user-images.githubusercontent.com/387249/154779355-64800de9-207c-4923-8f6c-e268d5ef057a.mp4