question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Brave News toolbar / Settings header isn't cleared on tab-overview page

See original GitHub issue

Description

Brave News toolbar / Settings header isn’t cleared on tab-overview page

Steps to reproduce

  1. install 1.37.5
  2. launch Brave
  3. tap through onboarding
  4. tap on the 3-dots menu on the bottom toolbar
  5. tap Settings
  6. tap Appearance
  7. tap to set Enable Tab Groups to Off
  8. tap RELAUNCH NOW
  9. swipe down
  10. tap to Show Brave News
  11. open a bunch of new-tab pages
  12. ensure you see the Brave News header w/Settings icon in at least one of the tabs
  13. add 2 or 3 more tabs
  14. now click on the tab-count eg [11] icon
  15. close all the tabs

Actual result

example example example
Screenshot_20220128-001032 Screenshot_20220128-001731 Screenshot_20220128-001748

https://user-images.githubusercontent.com/387249/151514086-81e0a165-269e-4ff9-848c-70ab3e2ae6e4.mp4

Expected result

The Brave News toolbar header shouldn’t persist in the tab-overview view

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL phone
  • Android version: 9.0

Brave version

1.37.5, Chromium 98.0.4758.74

cc @alexsafe @mattmcalister @srirambv @kjozwiak

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
srirambvcommented, Jan 28, 2022

This seems fixed on nightly. @stephendonner mind re-testing this one and close it out

cc: @alexsafe

0reactions
stephendonnercommented, Feb 19, 2022

Verified PASSED using 1.36.99, Chromium 98.0.4758.102 on a Google Pixel XL (arm64) running Android 9.0.

https://user-images.githubusercontent.com/387249/154779355-64800de9-207c-4923-8f6c-e268d5ef057a.mp4

Read more comments on GitHub >

github_iconTop Results From Across the Web

Brave News setting bar is not shown on the tab when loading ...
Enable News · Scroll down and load an article · Click on the home button and scroll down the feed, settings bar is...
Read more >
How to configure Brave UI, tabs - Desktop Support
On “Search” field type “scrollabe tabstrip.” Select the option “tabs don't shrink” or whatever suits you. Relaunch Brave. Profit.
Read more >
Images not displayed in Brave news - Mobile Support
On your extensions toolbar, right-click the extension you would like to remove. Select Remove from Brave… from the context menu. Additionally, ...
Read more >
Toolbar disappearance on page loading - Brave Community
The toolbar is great! But it should only be there on opening a new tab. Then, it should disappear, when a site is...
Read more >
Too much memory used - Desktop Support - Brave Community
Too much memory used · Activity Monitor, select the Memory tab (in the toolbar area), and select Shared Memory among the column header...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found