Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Brave reward/ad fetches should use SimpleURLLoader tied to user profile
See original GitHub issueSee https://github.com/brave/brave-core/pull/1756#issuecomment-466515552 for concerns about the current way Brave does background fetches in ads and rewards.
URLFetcher is used in https://github.com/brave/brave-core/blob/c6506166b093f2c3fb88e43007c05a5133993640/components/brave_rewards/browser/rewards_service_impl.cc#L1134 and https://github.com/brave/brave-core/blob/c6506166b093f2c3fb88e43007c05a5133993640/components/brave_ads/browser/ads_service_impl.cc#L892
It should use https://github.com/brave/brave-browser/wiki/Simple-Guide-to-SimpleURLLoader and be tied to the user profile
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@LaurenWags This was code refactoring. Marked as
QA/No. 😃+1 from https://github.com/brave/brave-browser/issues/4164