question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Cast is not disabled on toggling off media router switch in extension settings

See original GitHub issue

Description

Toggling off media router setting in brave://settings/extensions should disable

Test Plan

Specified here: https://github.com/brave/brave-core/pull/10116

Steps to Reproduce

  1. Enable cast by enabling the media router toggle in brave://settings/extensions
  2. Verify that cast functionality works
  3. Disable cast
  4. Cast should not be available in the hamburger menu

Actual result:

Cast still works

Expected result:

Cast should be disabled

Reproduces how often:

Easily reproduced

Desktop Brave version:

1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:9 (1 by maintainers)

github_iconTop GitHub Comments

3reactions
jumdecommented, Oct 2, 2021

@vis2x - The PR should be merged early next week.

0reactions
stephendonnercommented, Oct 18, 2021

Verified PASSED using

Brave 1.31.81 Chromium: 95.0.4638.40 (Official Build) beta (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. enabled network filter for Little Snitch
  2. new profile
  3. launched Brave
  4. loaded brave://settings/extensions and verifed that cast’s Media Router is disabled by default
  5. verified that SSDP requests are not sent by default
  6. toggled Media Router to On
  7. confirmed Relaunch button is visible
  8. loaded brave://flags and navigated back to brave://settings/extensions. Confirmed the Relaunch button is still visible
  9. restart browser
  10. verify cast works
  11. toggled Media Router in brave://settings/extensions to Off
  12. clicked on Relaunch
  13. verified I no longer see any cast / media-router options in YouTube or the top-level browser menus
example example example example example example
Screen Shot 2021-10-11 at 11 16 53 AM Screen Shot 2021-10-11 at 11 19 13 AM Screen Shot 2021-10-11 at 11 21 40 AM Screen Shot 2021-10-11 at 11 34 17 AM Screen Shot 2021-10-11 at 11 23 49 AM Screen Shot 2021-10-11 at 11 34 31 AM

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.31.86 Chromium: 95.0.4638.50
  • ensured that Media Router was enabled by default by visiting https://gem.cbc.ca/live/channel/ottawa and ensuring that the Cast icon was being displayed via the media player
  • ensured that tapping on the Cast button displayed a modal with all the devices that can cast
Example Example Example Example
Screenshot_20211018-165500_Brave 20211018_165541 Screenshot_20211018-165612_Brave image
Read more comments on GitHub >

github_iconTop Results From Across the Web

Brave keeps the "Cast" option enabled no matter what I do
Launch Brave; Observe that the Cast button in the hamburger menu is present and detecting my TV; Disable the Media Router extension in...
Read more >
How to fix Chromecast Source Not Supported Error?
Enable the Load Media Router Component Extension:​​ Launch Chrome and enter “chrome://flags/#media-router” in the address bar. Search for “Router ...
Read more >
Solution to Disable Chromecast via "#load-media-router ...
Disable the "Load Media Router Component Extension". Go to URL: chrome://flags/#load-media-router-component-extension. Select Disabled and ...
Read more >
Cannot disable Google Cast in Edge! - Microsoft Community
To access the Cast feature, open Settings and more (...) > More tools and select Cast media to device. Cast relies on the...
Read more >
How to Fix a Chromecast “Source Not Supported” Error
Enable the Load Media Router Component Extension ... The Media Router Component extension is used to cast your browser to your Chromecast-enabled ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found