Cast is not disabled on toggling off media router switch in extension settings
See original GitHub issueDescription
Toggling off media router setting in brave://settings/extensions should disable
Test Plan
Specified here: https://github.com/brave/brave-core/pull/10116
Steps to Reproduce
- Enable cast by enabling the media router toggle in
brave://settings/extensions - Verify that cast functionality works
- Disable cast
- Cast should not be available in the hamburger menu
Actual result:
Cast still works
Expected result:
Cast should be disabled
Reproduces how often:
Easily reproduced
Desktop Brave version:
1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:9 (1 by maintainers)
Top Results From Across the Web
Brave keeps the "Cast" option enabled no matter what I do
Launch Brave; Observe that the Cast button in the hamburger menu is present and detecting my TV; Disable the Media Router extension in...
Read more >How to fix Chromecast Source Not Supported Error?
Enable the Load Media Router Component Extension: Launch Chrome and enter “chrome://flags/#media-router” in the address bar. Search for “Router ...
Read more >Solution to Disable Chromecast via "#load-media-router ...
Disable the "Load Media Router Component Extension". Go to URL: chrome://flags/#load-media-router-component-extension. Select Disabled and ...
Read more >Cannot disable Google Cast in Edge! - Microsoft Community
To access the Cast feature, open Settings and more (...) > More tools and select Cast media to device. Cast relies on the...
Read more >How to Fix a Chromecast “Source Not Supported” Error
Enable the Load Media Router Component Extension ... The Media Router Component extension is used to cast your browser to your Chromecast-enabled ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

@vis2x - The PR should be merged early next week.
Verified
PASSEDusingSteps:
brave://settings/extensionsand verifed that cast’sMedia Routeris disabled by defaultMedia RoutertoOnRelaunchbutton is visiblebrave://flagsand navigated back tobrave://settings/extensions. Confirmed theRelaunchbutton is still visibleMedia Routerin brave://settings/extensions toOffRelaunchVerification PASSED on
Samsung S10+runningAndroid 11using the following build:Media Routerwas enabled by default by visiting https://gem.cbc.ca/live/channel/ottawa and ensuring that theCasticon was being displayed via the media playerCastbutton displayed a modal with all the devices that can castExampleExampleExampleExample